feat(toolchain): add text plain object property for createToolchainEvents#46
Merged
omar-albastami merged 20 commits intoIBM:mainfrom Oct 16, 2024
Merged
feat(toolchain): add text plain object property for createToolchainEvents#46omar-albastami merged 20 commits intoIBM:mainfrom
omar-albastami merged 20 commits intoIBM:mainfrom
Conversation
added 20 commits
September 3, 2024 10:41
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
…ent function BREAKING CHANGE: the textPlain string property is being replaced by a ToolchainEventPrototypeDataTextPlain object. String values must be provided using the ToolchainEventPrototypeDataTextPlain.content property Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
briangleeson
pushed a commit
that referenced
this pull request
Oct 16, 2024
# [2.0.0](1.9.0...2.0.0) (2024-10-16) ### Features * **toolchain:** add text plain object property for createToolchainEvents ([#46](#46)) ([16c8c0c](16c8c0c)) ### BREAKING CHANGES * **toolchain:** the textPlain string property is being replaced by a ToolchainEventPrototypeDataTextPlain object. String values must be provided using the ToolchainEventPrototypeDataTextPlain.content property Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com> * fix to test Signed-off-by: Omar Al Bastami <omar.albastami@ibm.com>
Member
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Updated SDK error formats. Also replaced the
TextPlainproperty withToolchainEventPrototypeDataTextPlainin theToolchainEventPrototypeData. This is a breaking change, and users will have to adjust accordingly.PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
Users can send text plain toolchain events by providing a string in the
ToolchainEventPrototypeData.textPlainpropertyWhat is the new behavior?
Users can send text plain toolchain events by providing a string in the
ToolchainEventPrototypeData.textPlain.contentpropertyDoes this PR introduce a breaking change?
Other information