Skip to content

Conversation

@rashmi43
Copy link
Member

@rashmi43 rashmi43 commented Sep 2, 2025

Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
@rashmi43 rashmi43 requested review from Tirumalavasa, abhishekp03 and rwhundley and removed request for rwhundley September 2, 2025 14:43
@rashmi43
Copy link
Member Author

rashmi43 commented Sep 2, 2025

Running make test and need to perform a final validation with Installer changes

@rashmi43
Copy link
Member Author

rashmi43 commented Sep 2, 2025

make test is successful:

(base) rashmi_kh@192 ibm-iam-operator % make test
go1.24.1: already downloaded in /Users/rashmi_kh/sdk/go1.24.1
/Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/controller-gen rbac:roleName=manager-role webhook paths="./..."
/Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
test -s /Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/gofmt 2>&1 || /Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/go1.24.1 build -o /Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/gofmt /Users/rashmi_kh/sdk/go1.24.1/src/cmd/gofmt
/Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/go1.24.1 fmt ./...
/Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/go1.24.1 vet ./...
KUBEBUILDER_ASSETS="/Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/k8s/1.28.3-darwin-amd64" /Users/rashmi_kh/Documents/GIT/IAM-OPERATOR/ibm-iam-operator/bin/go1.24.1 test $(go list ./... | grep -v /e2e) -coverprofile cover.out
	github.com/IBM/ibm-iam-operator/api/oidc.security/v1		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/api/operator/v1alpha1		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/cmd		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/internal/api/certmanager/v1		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/internal/api/certmanager/v1alpha1	coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/internal/api/zen.cpd.ibm.com/v1		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/internal/controller/bootstrap		coverage: 0.0% of statements
ok  	github.com/IBM/ibm-iam-operator/internal/controller/common	1.955s	coverage: 2.8% of statements
ok  	github.com/IBM/ibm-iam-operator/internal/controller/oidc.security	13.108s	coverage: 1.4% of statements
ok  	github.com/IBM/ibm-iam-operator/internal/controller/operator	16.140s	coverage: 22.1% of statements
	github.com/IBM/ibm-iam-operator/internal/database		coverage: 0.0% of statements
	github.com/IBM/ibm-iam-operator/internal/database/connectors		coverage: 0.0% of statements
ok  	github.com/IBM/ibm-iam-operator/internal/database/migration	1.711s	coverage: 33.3% of statements
ok  	github.com/IBM/ibm-iam-operator/internal/database/schema/v1	3.264s	coverage: 11.0% of statements
?   	github.com/IBM/ibm-iam-operator/internal/version	[no test files]
	github.com/IBM/ibm-iam-operator/test/utils		coverage: 0.0% of statements

rashmi43 and others added 4 commits September 4, 2025 14:40
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Copy link
Collaborator

@rwhundley rwhundley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail; please run make test and fix the code so that it passes.

rashmi43 and others added 3 commits September 5, 2025 20:14
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
Signed-off-by: rashmi_kh <rashmi.khanna@in.ibm.com>
@rashmi43 rashmi43 requested a review from rwhundley September 5, 2025 16:13
Signed-off-by: Rob Hundley <rwhundle@us.ibm.com>
@ibm-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmi43, rwhundley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rwhundley rwhundley merged commit 09c4fae into master Sep 5, 2025
1 check failed
@rwhundley rwhundley deleted the iam-um-mcsp branch September 5, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants