Update rbac yaml template due to error when using variables inside of loop #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
Daniel-Fan
approved these changes
Sep 30, 2025
Contributor
Daniel-Fan
left a comment
Daniel-Fan
left a comment
There was a problem hiding this comment.
The changes look good, thank you @bluzarraga !
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bluzarraga, Daniel-Fan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When testing the helm charts with the updated conditional labeling today, I saw a problem with the rbac.yaml. It is because of how variables are referenced from inside of a loop. This PR fixes this bug
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/67932