Skip to content

Fetch IAM Endpoint Dynamically #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 25, 2025
Merged

Fetch IAM Endpoint Dynamically #257

merged 13 commits into from
Aug 25, 2025

Conversation

@ashimagarg27
Copy link
Member

@ashimagarg27 ashimagarg27 commented Aug 19, 2025

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have made sure existing UTs are not impacted
  • I have executed all necessary linter and made sure internal pipeline/travis is not broken

@ashimagarg27
update versions
42e73b7
@ashimagarg27
update versions
62dec5d
@ashimagarg27
fetch iam endpoint dynamically
e8b8fb0 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
Bhagyashreek8
Bhagyashreek8 previously approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@Bhagyashreek8 Bhagyashreek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ashimagarg27
ashimagarg27 commented Aug 20, 2025
View reviewed changes
@ashimagarg27
fix uts
1eeae3f 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
ashimagarg27 and others added 7 commits August 20, 2025 12:24
@ashimagarg27
publish v0.9.0
3b33b32 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
publish v0.9.1
282dfe9 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
fix travis
af2a737 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
publish v0.9.1
c4b1588 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
revert version
570bd77 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
revert version
c22b6ff 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
Merge branch 'main' into ashima2
59d750f
Bhagyashreek8
Bhagyashreek8 previously approved these changes Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@Bhagyashreek8 Bhagyashreek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mssachan
mssachan reviewed Aug 24, 2025
View reviewed changes
mssachan
mssachan reviewed Aug 24, 2025
View reviewed changes
mssachan
mssachan requested changes Aug 24, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added minor comment. PTAL

@ashimagarg27
address review comments
2822e29 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
minor fixes
7f074d6 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
mssachan
mssachan approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashimagarg27 ashimagarg27 merged commit 1d5d20f into main Aug 25, 2025
3 checks passed
@ashimagarg27 ashimagarg27 deleted the ashima2 branch August 25, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mssachan mssachan mssachan approved these changes

@Bhagyashreek8 Bhagyashreek8 Bhagyashreek8 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashimagarg27 @mssachan @Bhagyashreek8