Edit a2a agent functionality, minor view screen and filterEntities via tag fixes #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS0713
force-pushed
the
edit_a2a_agent_functionality
branch
2 times, most recently
from
b13c988 to
836eb9a
Compare
rakdutta
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
A2A edit functionality is working as expected. Filtering entities by tags is also functioning correctly. For the virtual server, please note that it was searched using the tag and not the server name. Hence, the text changes are appropriate. PR is ready merge.
TS0713
force-pushed
the
edit_a2a_agent_functionality
branch
2 times, most recently
from
3166642 to
bceb2c3
Compare
…ew a2a agents, fixed filter entities via tags for prompts/resources/a2a agents Signed-off-by: Satya <tsp.0713@gmail.com> Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit. interactive rebase in progress; onto 878f350 Last command done (1 command done): pick 6a2f4cf edit functionality for a2a agents, minor changes in add a2a agents/view a2a agents, fixed filter entities via tags for prompts/resources/a2a agents Next commands to do (2 remaining commands): pick 596c1c4 fixing doctest failures pick 1ecd66b lint web fixes You are currently rebasing branch 'edit_a2a_agent_functionality' on '878f350f'. Changes to be committed: modified: mcpgateway/admin.py modified: mcpgateway/db.py modified: mcpgateway/schemas.py modified: mcpgateway/services/a2a_service.py modified: mcpgateway/static/admin.js modified: mcpgateway/templates/admin.html
modified: mcpgateway/admin.py modified: mcpgateway/db.py modified: mcpgateway/schemas.py modified: mcpgateway/services/a2a_service.py modified: mcpgateway/static/admin.js modified: mcpgateway/templates/admin.html
Signed-off-by: Satya <tsp.0713@gmail.com>
…ther minor changes, replicated populate auth, encode & decode for auth types Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
…whitespace Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
- Fix import order in bootstrap_db.py: move sqlalchemy before alembic - Replace invalid 'always_print_fields_with_no_presence' parameter with 'including_default_value_fields' in translate_grpc.py - Parameter was removed/renamed in protobuf >=6.33.0 Pylint now passes with 10.00/10 rating. All tests continue to pass (3624 passed, 87 skipped). Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
edit_a2a_agent_functionality
branch
from
bceb2c3 to
b54ce35
Compare
crivetimihai
approved these changes
Oct 29, 2025
|
Closes #1020 |
crivetimihai
added a commit
that referenced
this pull request
Oct 30, 2025
…agents PR #1270 added oauth_config and passthrough_headers to the A2AAgent model but forgot to include the database migration. This caused SQLAlchemy errors when querying a2a_agents from older databases. This migration: - Adds oauth_config column (JSON, nullable) - Adds passthrough_headers column (JSON, nullable) - Creates idx_a2a_agents_team_visibility index for query performance - Creates idx_a2a_agents_owner_visibility index for query performance The indexes match the pattern used for other resource tables (tools, servers, gateways, etc.) and are critical for multitenancy/RBAC query performance. Fixes SQLAlchemy OperationalError: no such column: a2a_agents.oauth_config Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Merged
crivetimihai
added a commit
that referenced
this pull request
Oct 30, 2025
* fix: Add missing oauth_config and passthrough_headers columns to a2a_agents PR #1270 added oauth_config and passthrough_headers to the A2AAgent model but forgot to include the database migration. This caused SQLAlchemy errors when querying a2a_agents from older databases. This migration: - Adds oauth_config column (JSON, nullable) - Adds passthrough_headers column (JSON, nullable) - Creates idx_a2a_agents_team_visibility index for query performance - Creates idx_a2a_agents_owner_visibility index for query performance The indexes match the pattern used for other resource tables (tools, servers, gateways, etc.) and are critical for multitenancy/RBAC query performance. Fixes SQLAlchemy OperationalError: no such column: a2a_agents.oauth_config Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * Linting Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue #1020