Make users change default admin passwords and secrets for production deployments #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deployments Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Signed-off-by: NAYANAR <nayana.r5@ibm.com>
|
I just plowed through a whole bunch of passwords and other secrets in config.py that were not using SecretStr, so you may want to look at #1330 and rebase or integrate to it, perhaps with SecretStr conditional logic. |
…afe environment, sends input, and ensures proper cleanup Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Nayana-R-Gowda
requested review from
kevalmahajan and
madhav165
as code owners
…n for the “hardcoded password string” rule Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Signed-off-by: NAYANAR <nayana.r5@ibm.com>
…t, or remove its shebang Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANAR nayana.r5@ibm.com
🐛 Bug-fix PR
📌 Summary
What problem does this PR fix and why?
Make users change default admin passwords and secrets for production deployments
🧪 Verification
make lintmake test📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)