fix resource uri template listing #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS0713
force-pushed
the
resource_template_uri_fix
branch
3 times, most recently
from
1de20a2 to
74ab7b7
Compare
TS0713
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
… for resource table Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
…scenarious modified few tests related to read_resource updated viewResource inside admin.js resourceURI to resourceID (just a name change) Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
TS0713
force-pushed
the
resource_template_uri_fix
branch
from
0f8c4f1 to
ac73126
Compare
crivetimihai
added a commit
that referenced
this pull request
Nov 25, 2025
- Rename 'template' column to 'uri_template' in Resource model for clarity
- Add Alembic migration (191a2def08d7) to rename the column
- Update schemas (ResourceCreate, ResourceUpdate, ResourceRead) to use uri_template
- Add uri_template field to ResourceRead for API responses
- Fetch and store resource templates when registering MCP gateways
- Update URI validation pattern to allow curly braces {} for templates
- Fix read_resource to accept either resource_id or resource_uri
- Update ResourceTemplate model to use proper JSON alias (uriTemplate)
- Update all related tests to use new field name
Closes #1455
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
approved these changes
Nov 25, 2025
crivetimihai
added a commit
that referenced
this pull request
Nov 25, 2025
- Rename resource table field 'template' to 'uri_template' for clarity
- Add Alembic migration script for column rename
- Update resource_service.py read_resource to use either resource_id or resource_uri
- Fix resource template URI handling in gateway_service.py
- Include Resource of type URI template from MCP server when registering
- Update VALIDATION_SAFE_URI_PATTERN to allow {} characters for templates
- Fix related test cases for resource URI templates
Closes #1455
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR handles below items: