Skip to content

Bh/make uv use global venv instead of creating project one #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2025
Merged

Bh/make uv use global venv instead of creating project one #1482

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cce6b3e
Update uv commands to use the global venv instead of using a second v…
brian-hussey Nov 19, 2025
442de40
Activate virtualenv for pylint and pre-commit tasks
brian-hussey Nov 19, 2025
c6a8515
Update for readability
brian-hussey Nov 20, 2025
a72ac86
Use virtualenv for smoketest
brian-hussey Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ clean:
## --- Automated checks --------------------------------------------------------
smoketest:
@echo "🚀 Running smoketest..."
@bash -c '\
@/bin/bash -c 'source $(VENV_DIR)/bin/activate && \
./smoketest.py --verbose || { echo "❌ Smoketest failed!"; exit 1; }; \
echo "✅ Smoketest passed!" \
'
Expand All @@ -443,15 +443,15 @@ test:
@/bin/bash -c "source $(VENV_DIR)/bin/activate && \
export DATABASE_URL='sqlite:///:memory:' && \
export TEST_DATABASE_URL='sqlite:///:memory:' && \
uv run pytest -n auto --maxfail=0 -v --ignore=tests/fuzz"
uv run --active pytest -n auto --maxfail=0 -v --ignore=tests/fuzz"

test-profile:
@echo "🧪 Running tests with profiling (showing slowest tests)..."
@test -d "$(VENV_DIR)" || $(MAKE) venv
@/bin/bash -c "source $(VENV_DIR)/bin/activate && \
export DATABASE_URL='sqlite:///:memory:' && \
export TEST_DATABASE_URL='sqlite:///:memory:' && \
uv run pytest -n auto --durations=20 --durations-min=1.0 --disable-warnings -v --ignore=tests/fuzz"
uv run --active pytest -n auto --durations=20 --durations-min=1.0 --disable-warnings -v --ignore=tests/fuzz"

coverage:
@test -d "$(VENV_DIR)" || $(MAKE) venv
Expand Down Expand Up @@ -1027,7 +1027,9 @@ flake8: ## 🐍 flake8 checks

pylint: uv ## 🐛 pylint checks
@echo "🐛 pylint $(TARGET) (parallel)..."
uv run pylint -j 0 --fail-on E --fail-under 10 $(TARGET)
@test -d "$(VENV_DIR)" || $(MAKE) venv
@/bin/bash -c "source $(VENV_DIR)/bin/activate && \
uv run --active pylint -j 0 --fail-on E --fail-under 10 $(TARGET)"

markdownlint: ## 📖 Markdown linting
@# Install markdownlint-cli2 if not present
Expand Down Expand Up @@ -1073,7 +1075,9 @@ pycodestyle: ## 📝 Simple PEP-8 checker

pre-commit: uv ## 🪄 Run pre-commit tool
@echo "🪄 Running pre-commit hooks..."
uv run pre-commit run --config .pre-commit-lite.yaml --all-files --show-diff-on-failure
@test -d "$(VENV_DIR)" || $(MAKE) venv
@/bin/bash -c "source $(VENV_DIR)/bin/activate && \
uv run --active pre-commit run --config .pre-commit-lite.yaml --all-files --show-diff-on-failure"

ruff: ## ⚡ Ruff lint + (eventually) format
@echo "⚡ ruff $(TARGET)..." && $(VENV_DIR)/bin/ruff check $(TARGET)
Expand Down
Loading