service program parameter pass by value

[jkdavew]

XMLSERVICE 1.9.9.3 (03–13–2017) reported a fix for by="val" to be on , not but it looks like itoolkit is still passing it on the tag. This is a problem when using itoolkit with a procedure containing a parameter passed by value in a service program.

[abmusse]

PR #36

[jkdavew]

Abdirahim, I went to sign and notice the signature was wrong. I got a new laptop and did the sign before realizing it wasn't linked to my Github account. Because of that my signature was wrong. I tried several other attempts but nothing seemed to work. I also tried to rebase with no luck. Ideally I want to undo all of my commit this morning and start over! I'd imagine you're much more familiar with Git and could use your guidance. Thanks, Dave

…

On Wed, Feb 27, 2019 at 5:00 PM Abdirahim Musse ***@***.***> wrote: PR #36 <#36> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APFeQZEYt9fEpdoq75VHrR3zFUMIOw_Mks5vRv_lgaJpZM4a5qbq> .

[kadler]

@jkdavew you can use git rebase -i to rebase the commits. You need to pass a parent commit (the one before your commits). Then you can change the "pick" to "reword" or "r" to edit the commit message for each of those commits. Add or edit the "Signed-off-by" tag in the commit message for each one. Once that's done, you can git push --force to replace the PR commits with the new commits.

Here's a good article about doing this: https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history

If you get stuck, feel free to ask for more help.

[abmusse]

@jkdavew

Ideally I want to undo all of my commit this morning and start over!

Using git rebase -i as mentioned by @kadler

You can also drop unwanted commits by changing "pick" to "drop" on the unwanted commit.

[kadler]

Using git reset will be easier. I documented it over on the PR: #36 (comment)

[jkdavew]

I see this has been approved & merged, but it's not yet in NPM. Curious what the migration plan is for that environment. Also - should I be deleting my forked repo (seen some mixed information regarding best practice).

[kadler]

The usual cleanup duties are to delete the branch you submitted the PR from, but in this case I see that you did it from your master branch, so in that case you would not do that. (Note: The usual best practice is to always create a branch before making changes).

As to cleaning up the repo, you can do that if you like or leave it to rot (there's a lot of rotting forks on GitHub). GitHub recently added a feature to do this once your PR is closed: isaacs/github#673 (comment), though it may be in beta or something as I haven't seen any blog post advertising it. Otherwise, you can follow the guide here: https://help.github.com/en/articles/deleting-a-repository

[jkdavew]

I think I originally did it from master, but then from a branch instead. For now I'll just leave it alone.... Maybe when the pr gets closer it will do some cleanup as you mentioned. What about the npm module... Does the get updated separately from your team?

…

On Thu, Mar 21, 2019, 5:12 PM Kevin Adler ***@***.***> wrote: The usual cleanup duties are to delete the branch you submitted the PR from, but in this case I see that you did it from your master branch, so in that case you would not do that. (Note: The usual best practice is to always create a branch before making changes). As to cleaning up the repo, you can do that if you like or leave it to rot (there's a lot of rotting forks on GitHub). GitHub recently added a feature to do this once your PR is closed: isaacs/github#673 (comment) <isaacs/github#673 (comment)>, though it may be in beta or something as I haven't seen any blog post advertising it. Otherwise, you can follow the guide here: https://help.github.com/en/articles/deleting-a-repository — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APFeQX8SqUw6WLZ3Ma_wpxRBQ3DL-NxGks5vY_WlgaJpZM4a5qbq> .

[abmusse]

@dmabupt @ThePrez

Can we release a new version 0.1.7?

@jkdavew PR #43 was merged into master.

[abmusse]

@jkdavew

https://www.npmjs.com/package/itoolkit/v/1.0.0-alpha.0

This release includes the changes from your PR.

npm install itoolkit@alpha

We are working towards a stable v1.0.0 soon.

[jkdavew]

Great thank you!