fix: eslint errors #243
Merged
fix: eslint errors #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmusse
commented
Apr 8, 2020
| const lib = 'NODETKTEST'; | ||
| const createLib = `CRTLIB LIB(${lib}) TYPE(*TEST) TEXT('Used to test Node.js toolkit')`; | ||
| const findLib = `SELECT SCHEMA_NAME FROM qsys2.sysschemas WHERE SCHEMA_NAME = '${lib}'`; | ||
| const dataQueue = 'TESTQ'; |
Member
Author
There was a problem hiding this comment.
Fixes
../nodejs-itoolkit/test/functional/checkObjectExists.js
4:7 error 'dataQueue' is assigned a value but never used no-unused-vars
5:7 error 'dataArea' is assigned a value but never used no-unused-vars
abmusse
commented
Apr 8, 2020
| // REST transport currently failing with 414 URI Too Long response code | ||
| // The requested URL's length exceeds the capacity limit for this server | ||
| describe('getInstalledProducts', () => { | ||
| // eslint-disable-next-line func-names |
abmusse
commented
Apr 8, 2020
| if (error) { throw error; } | ||
|
|
||
| checkObjectExists(config, dqName2, '*DTAQ', (error) => { | ||
| if (error) { throw error; } |
Member
Author
There was a problem hiding this comment.
Fixes
../nodejs-itoolkit/test/functional/iDataQueueFunctional.js
37:52 error 'error' is already declared in the upper scope no-shadow
abmusse
commented
Apr 8, 2020
| xmlOutput += chunk.OUT151; | ||
| }); | ||
| done(null, xmlOutput); | ||
| return; |
Member
Author
There was a problem hiding this comment.
Fixes
../nodejs-itoolkit/lib/transports/idbTransport.js
104:11 error Unnecessary return statement no-useless-return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242