fix: HTTP transport should take a URL #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadler
approved these changes
Apr 22, 2020
Member
kadler
left a comment
kadler
left a comment
There was a problem hiding this comment.
LGTM other than the password check using the same error message as the url check.
kadler
approved these changes
Apr 22, 2020
abmusse
commented
Apr 30, 2020
| // construct the url host:port/path | ||
| options.transportOptions.url = `http://${option.host}:${option.port || 80}${option.path || '/'}`; | ||
| } | ||
| options.transportOptions = { ...options.transportOptions, ...option }; |
Member
Author
There was a problem hiding this comment.
Looks like this change is the cause of unit test failure. We should still append user passed options to the transportOptions like we did before.
Member
There was a problem hiding this comment.
Oops. I should have caught that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247