Skip to content

Conversation

@yhwang
Copy link
Member

@yhwang yhwang commented Oct 2, 2025

fix some indentations, update mkdocs deps,
and make the last code snippet be able to be pasted to
python interpreter directly.

@jbusche
Copy link
Member

jbusche commented Oct 3, 2025

LGTM! Thanks for fixing the formatting issues. What do you think @jjasghar? Do you like the uv option in Lab7?

@yhwang
Copy link
Member Author

yhwang commented Oct 3, 2025

tried to provide uv as the alternative option in the change, which aligns with the mellea doc that I see here. it shouldn't change anything if user sticks with the venv + python.

@jjasghar
Copy link
Member

jjasghar commented Oct 3, 2025

I totally understand why you chose this, but it prefer not to reference uv at all.

There already is a lot to get here, and remember we have know way of knowing if our audience knows what a virtual environment is, we do this stuff everyday but our audience doesn't so more abstractions only cause possible confusion.

@yhwang yhwang force-pushed the update-the-last-mellea-code-section branch from ad645a9 to 4cb5ba0 Compare October 4, 2025 00:12
@yhwang
Copy link
Member Author

yhwang commented Oct 4, 2025

@jjasghar understood. updated the content to only fix the indentation issues and made the last code snippet be able to be pasted to the python interpreter directly.

@yhwang yhwang changed the title add uv instruction fix formatting issue and last code snippet of lab 7 Oct 4, 2025
fix some indentations, update mkdocs deps,
and make the last code snippet be able to be pasted to
python interpreter directly.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@yhwang yhwang force-pushed the update-the-last-mellea-code-section branch from 4cb5ba0 to d0e7dcd Compare October 4, 2025 00:17
@jbusche
Copy link
Member

jbusche commented Oct 4, 2025

Thank you @yhwang

@jbusche
Copy link
Member

jbusche commented Oct 4, 2025

LGTM

@jjasghar jjasghar merged commit d41eef3 into IBM:main Oct 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants