feat(iam-identity): adding trusted profiles by pooraniss-ibm · Pull Request #119 · IBM/platform-services-java-sdk

pooraniss-ibm · 2021-08-18T02:11:59Z

PR summary

This pr contains all the supported endpoints of Iam-Identity's trusted profiles.
we recently went public and here is the documentation: https://test.cloud.ibm.com/apidocs/iam-identity-token-api

PR Checklist

Please make sure that your PR fulfills the following requirements:

The commit message follows the Angular Commit Message Guidelines.
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

Yes
No

Other information

CLAassistant · 2021-08-18T02:12:03Z

All committers have signed the CLA.

Andras-Csanyi · 2021-08-18T21:09:19Z

Overall looks good!

One thing I'd like to ask is regarding testing. Please add additional integration tests for the newly added operations. These tests shoud cover 4xx and 5xx (if there is any) status codes. If you run the openapi-sdkgen tool (with -o swtich you can redirect the output to a different directory and it doesn't mess up your code) with the openapi description and with --genITs switch, then we generate comments about the status codes should be added. I would suggest cover only those 4xx and 5xx status codes which can be tested programmatically. For example, a 500 is out of scope, but a 404 or 400 is in the scope. You can find examples here: https://github.com/IBM/platform-services-java-sdk/blob/main/modules/catalog-management/src/test/java/com/ibm/cloud/platform_services/catalog_management/v1/CatalogManagementIT.java

Could please you attach a screenshot about the successful integration tests?

Andras-Csanyi

See my comments

pooraniss-ibm · 2021-08-30T08:41:12Z

adding additional tests to covers 400's, and the lint fixes are done. screenshot of integration test result is attached.

Andras-Csanyi

As I compared the 4 SDKs exampels I found a few inconsistencies.

pooraniss-ibm · 2021-09-02T08:52:38Z

this PR is now updated, all the typos and suggested changes are added :)

Andras-Csanyi

Two small fix is needed in the documentation tags

Andras-Csanyi

When the PR build finishes and it is green I'll merge it.

# [0.20.0](0.19.2...0.20.0) (2021-09-02) ### Features * **iam-identity:** adding trusted profiles ([#119](#119)) ([b26d60a](b26d60a))

ibm-devx-sdk · 2021-09-02T14:40:50Z

🎉 This PR is included in version 0.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [0.19.2](IBM/platform-services-node-sdk@v0.19.1...v0.19.2) (2021-07-21) ### Bug Fixes * add public publish option ([IBM#119](IBM/platform-services-node-sdk#119)) ([68e38e3](IBM/platform-services-node-sdk@68e38e3))

pooraniss-ibm requested a review from Andras-Csanyi August 18, 2021 02:11

Andras-Csanyi reviewed Aug 18, 2021

View reviewed changes

Comment thread ...mples/src/main/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityExamples.java

Andras-Csanyi reviewed Aug 18, 2021

View reviewed changes

Comment thread ...n/java/com/ibm/cloud/platform_services/iam_identity/v1/model/ProfileClaimRuleConditions.java

Andras-Csanyi reviewed Aug 18, 2021

View reviewed changes

Comment thread ...am-identity/src/test/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityIT.java Outdated

Andras-Csanyi reviewed Aug 18, 2021

View reviewed changes

Comment thread ...am-identity/src/test/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityIT.java

Andras-Csanyi suggested changes Aug 18, 2021

View reviewed changes

pooraniss-ibm requested a review from Andras-Csanyi August 25, 2021 00:09

Andras-Csanyi reviewed Sep 1, 2021

View reviewed changes

Comment thread ...mples/src/main/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityExamples.java Outdated