Skip to content

feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs#180

Merged
padamstx merged 9 commits intoIBM:mainfrom
Jdatechong:main
Mar 29, 2023
Merged

feat(Enterprise Billing Units): add start and limit parameters to billing unit APIs#180
padamstx merged 9 commits intoIBM:mainfrom
Jdatechong:main

Conversation

@Jdatechong
Copy link
Copy Markdown
Contributor

PR summary

Adds start and limit parameters to support pagination for certain Enterprise Billing Units APIs

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Results can now be optionally paginated using the start and limit parameters.

Does this PR introduce a breaking change?

  • Yes
  • No

Test results

[INFO] Reactor Summary:
[INFO] 
[INFO] IBM Cloud Platform Services Java SDK 99-SNAPSHOT ... SUCCESS [ 16.608 s]
[INFO] IBM Cloud Platform Services SDK Common Library ..... SUCCESS [ 29.924 s]
[INFO] IBM Cloud Case Management API ...................... SUCCESS [03:15 min]
[INFO] IBM Cloud Catalog Management API ................... SUCCESS [40:58 min]
[INFO] IBM Cloud Context-Based Restrictions API ........... SUCCESS [24:24 min]
[INFO] IBM Cloud Enterprise Billing Units API ............. SUCCESS [02:12 min]
[INFO] IBM Cloud Enterprise Management API ................ SUCCESS [07:39 min]
[INFO] IBM Cloud Enterprise Usage Reports API ............. SUCCESS [06:37 min]
[INFO] IBM Cloud Global Catalog API ....................... SUCCESS [40:10 min]
[INFO] IBM Cloud Global Search and Tagging - Search API ... SUCCESS [06:09 min]
[INFO] IBM Cloud Global Search and Tagging - Tagging API .. SUCCESS [02:41 min]
[INFO] IBM Cloud IAM Access Groups API .................... SUCCESS [04:29 min]
[INFO] IBM Cloud IAM Identity Services API ................ SUCCESS [  01:32 h]
[INFO] IBM Cloud IAM Policy Management API ................ SUCCESS [  02:01 h]
[INFO] IBM Cloud Shell Account Settings API ............... SUCCESS [01:33 min]
[INFO] IBM Cloud Open Service Broker API .................. SUCCESS [02:54 min]
[INFO] IBM Cloud Resource Controller API (v2) ............. SUCCESS [  02:03 h]
[INFO] IBM Cloud Resource Manager API ..................... SUCCESS [02:09 min]
[INFO] IBM Cloud Usage Metering API ....................... SUCCESS [01:34 min]
[INFO] IBM Cloud Usage Reports API ........................ SUCCESS [  01:47 h]
[INFO] IBM Cloud User Management API ...................... SUCCESS [02:49 min]
[INFO] IBM Cloud Platform Services Test Coverage Reports .. SUCCESS [ 31.888 s]
[INFO] IBM Cloud Platform Services Code Examples 99-SNAPSHOT SUCCESS [ 41.418 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

…ling unit APIs

Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@padamstx padamstx self-assigned this Feb 2, 2023
@padamstx padamstx self-requested a review February 2, 2023 16:04
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit actually added new generated code in the wrong place. When running the generator (while in the project root directory), use option -o ./modules so that the generated java source files will be located in ./modules/enterprise-billing-units/src and not enterprise-billing-units/src.

Jdatechong and others added 4 commits February 7, 2023 16:20
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just let me know when the PR should be merged.

Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@Jdatechong
Copy link
Copy Markdown
Contributor Author

Examples results:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25.514 s
[INFO] Finished at: 2023-03-28T18:00:37-07:00
[INFO] ------------------------------------------------------------------------

Integration tests results:

[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.392 s - in com.ibm.cloud.platform_services.enterprise_billing_units.v1.EnterpriseBillingUnitsIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M7:verify (default) @ enterprise-billing-units ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45.655 s
[INFO] Finished at: 2023-03-28T17:56:44-07:00
[INFO] ------------------------------------------------------------------------

@padamstx padamstx merged commit 1cb08b1 into IBM:main Mar 29, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Mar 29, 2023
# [0.31.0](0.30.2...0.31.0) (2023-03-29)

### Features

* **Enterprise Billing Units:** add start and limit parameters to billing unit list APIs ([#180](#180)) ([1cb08b1](1cb08b1))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants