feat(IAM Identity): add trusted profile identities api#196
Merged
Conversation
Somchavan
changed the title
padamstx
changed the title
padamstx
suggested changes
May 31, 2023
Contributor
padamstx
left a comment
padamstx
left a comment
There was a problem hiding this comment.
Looks good, except for the issue with the set_profile_identities operation that I commented about.
Somchavan
force-pushed
the
iam-identity-profile-identities
branch
from
8baff53 to
ba2967c
Compare
padamstx
suggested changes
Jun 1, 2023
Contributor
padamstx
left a comment
padamstx
left a comment
There was a problem hiding this comment.
Everything looks good except that the staging version of the API was used to generate the code. Please re-gen again with the production API (or the version of the API that will eventually be merged into the production branch... it could be sitting in a PR branch or something)
Signed-off-by: Somanath Chavan <somanath.chavan@ibm.com>
Somchavan
force-pushed
the
iam-identity-profile-identities
branch
from
ba2967c to
b32b88c
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 9, 2023
# [0.36.0](0.35.0...0.36.0) (2023-06-09) ### Features * **IAM Identity:** add trusted profile identities API ([#196](#196)) ([162d0fd](162d0fd))
Contributor
|
🎉 This PR is included in version 0.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Added feature support for Trusted Profile identities work, add, get, delete identities associated with the profile.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to call Trusted profile identities APIs.
Does this PR introduce a breaking change?
Other information
API defintion:
Staging
Test information:
Integration Tests:
PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetReportMfaComplete PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteApiKey1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateServiceIdNegative PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetApiKeysDetails PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateProfileBadRequest PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateClaimRule2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateLinkBadRequest PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetApiKey PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetAccountSettings PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetReportComplete PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateProfile2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteClaimRule1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetProfile PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteProfile1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateClaimRuleBadRequest PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateApiKey2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testListClaimRules PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetServiceIdNegative PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testSetProfileIdentity PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteClaimRule2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetReportIncomplete PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateApiKey PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteLink PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateProfile1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetProfileNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateAccountSettings PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testSetProfileIdentities PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateApiKey1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetMfaStatus PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateProfile PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateClaimRuleNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testListServiceIds PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteLinkNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateLink PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateProfileUnauthorised PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateReport PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateProfileNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateClaimRule PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateClaimRule1 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteProfile2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetClaimRule PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteApiKeyNegative PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUnlockApiKey PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetLink PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteProfileNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetClaimRuleNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetReportNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateApiKeyNegative PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateReportMfa PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteClaimRuleNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetProfileIdentity PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testLockApiKey PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testLockServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testListLinks PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testCreateServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetProfileIdentities PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetReportMfaNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testListApiKeys PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUpdateClaimRuleBadRequest PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteProfileIdentity PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testDeleteApiKey2 PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testUnlockServiceId PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testGetLinkNotFound PASSED: com.ibm.cloud.platform_services.iam_identity.v1.IamIdentityIT.testListProfiles =============================================== Default test Tests run: 67, Failures: 0, Skips: 0 =============================================== =============================================== Default suite Total tests run: 67, Passes: 67, Failures: 0, Skips: 0 ===============================================