Skip to content

Conversation

@Rajesh-Pirati
Copy link
Contributor

PR summary

Authorization policy type support for enterprise accounts
issue: https://github.ibm.com/IAM/AM-issues/issues/2350

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

getPolicyAssignment() result:
{
  "target": {
    "type": "Account",
    "id": "0ddc8e9eb0894383b48791ff4ba0b80e"
  },
  "options": {
    "root": {
      "requester_id": "test_sdk",
      "assignment_id": "test"
    }
  },
  "id": "policyAssignment-d4c8c37e-57ef-42ea-a0e3-811184a4d55a",
  "account_id": "e3aa0adff348470f803d4b6e53d625cf",
  "href": "https://iam.test.cloud.ibm.com/v1/policy_assignments/policyAssignment-d4c8c37e-57ef-42ea-a0e3-811184a4d55a",
  "created_at": "2024-04-18T07:25:08.435Z",
  "created_by_id": "test_sdk",
  "last_modified_at": "2024-04-18T07:25:18.763Z",
  "last_modified_by_id": "test_sdk",
  "resources": [
    {
      "target": {
        "id": "0ddc8e9eb0894383b48791ff4ba0b80e"
      },
      "policy": {
        "resource_created": {
          "id": "9bb2f599-9061-4669-88af-89a6ad717887"
        }
      }
    }
  ],
  "template": {
    "id": "policyTemplate-b371dc76-a43e-4052-952a-7d5405fc7466",
    "version": "2"
  },
  "status": "succeeded"
}
getTemplateMetaDataV2AccessPolicy() result:
{
  "id": "policyTemplate-b371dc76-a43e-4052-952a-7d5405fc7466",
  "version": "2",
  "assignment_id": "policyAssignment-d4c8c37e-57ef-42ea-a0e3-811184a4d55a"
}
deletePolicyAssignment() result:
deletePolicyTemplateVersion() response status code: 204
deletePolicyTemplate() response status code: 204
[WARNING] thread Thread[#35,OkHttp TaskRunner,5,com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementExamples] was interrupted but is still alive after waiting at least 15000msecs
[WARNING] thread Thread[#35,OkHttp TaskRunner,5,com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementExamples] will linger despite being asked to die via interruption
[WARNING] thread Thread[#36,Okio Watchdog,5,com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementExamples] will linger despite being asked to die via interruption
[WARNING] NOTE: 2 thread(s) did not finish despite being asked to via interruption. This is not a problem with exec:java, it is a problem with the running code. Although not serious, it should be remedied.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  44.225 s
[INFO] Finished at: 2024-04-18T12:55:36+05:30
[INFO] ------------------------------------------------------------------------

integration results:

[INFO] Running com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.24 s -- in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- failsafe:3.1.2:verify (default) @ iam-policy-management ---
[INFO] 
[INFO] --- install:3.1.1:install (default-install) @ iam-policy-management ---
[INFO] Installing /Users/rajesh/iam-project/platform-sdk/platform-services-java-sdk/modules/iam-policy-management/pom.xml to /Users/rajesh/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.pom
[INFO] Installing /Users/rajesh/iam-project/platform-sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT.jar to /Users/rajesh/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.jar
[INFO] Installing /Users/rajesh/iam-project/platform-sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-javadoc.jar to /Users/rajesh/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-javadoc.jar
[INFO] Installing /Users/rajesh/iam-project/platform-sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-sources.jar to /Users/rajesh/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:14 min
[INFO] Finished at: 2024-04-17T17:32:01+05:30
[INFO] ------------------------------------------------------------------------

Signed-off-by: Rajesh K Pirati <rajesh.pirati@ibm.com>
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@swcolley swcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@padamstx padamstx self-assigned this Apr 18, 2024
@padamstx padamstx self-requested a review April 18, 2024 18:39
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 115888a into main Apr 18, 2024
@padamstx padamstx deleted the enterprise-s2s-support branch April 18, 2024 19:15
ibm-devx-sdk pushed a commit that referenced this pull request Apr 18, 2024
## [0.53.3](0.53.2...0.53.3) (2024-04-18)

### Bug Fixes

* **IAM Policy Management:** S2S support for enterprise accounts ([#241](#241)) ([115888a](115888a))
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.53.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants