Skip to content

Conversation

@fabrizio-leoni
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Fabrizio Leoni <fabrizio_leoni@it.ibm.com>
@fabrizio-leoni fabrizio-leoni requested a review from padamstx June 21, 2024 09:45
@fabrizio-leoni
Copy link
Contributor Author

image

@fabrizio-leoni
Copy link
Contributor Author

image

@fabrizio-leoni
Copy link
Contributor Author

fabrizio-leoni commented Jun 21, 2024

@padamstx I notidìced that in this repository the file pom.xml contains a section with this tag <jacoco-plugin-version>0.8.10</jacoco-plugin-version> even if it seems wrong. The right version should be 0.8.11
Do you prefer I will commit the file pom.xml the new jacoco-plugin version or not?

@padamstx padamstx self-assigned this Jun 21, 2024
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx
Copy link
Contributor

@padamstx I notidìced that in this repository the file pom.xml contains a section with this tag <jacoco-plugin-version>0.8.10</jacoco-plugin-version> even if it seems wrong. The right version should be 0.8.11 Do you prefer I will commit the file pom.xml the new jacoco-plugin version or not?

I can make that change after this PR is merged.

@padamstx padamstx merged commit 4b5e597 into main Jun 21, 2024
@padamstx padamstx deleted the java-sdk-2q branch June 21, 2024 22:23
ibm-devx-sdk pushed a commit that referenced this pull request Jun 21, 2024
## [0.54.1](0.54.0...0.54.1) (2024-06-21)

### Bug Fixes

* **Global Tagging:** add 'update' option to attach_tag operation ([#247](#247)) ([4b5e597](4b5e597))
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.54.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants