feat(IAM Policy Management): add access management account settings API #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelum Senanayake <kelumkps@yahoo.com>
|
|
kelumkps
commented
Mar 19, 2025
| } | ||
|
|
||
| @Test(dependsOnMethods = { "testCreateS2SPolicyTemplate" }) | ||
| public void testCreatePolicyAssignmentError() throws Exception { |
Member
Author
There was a problem hiding this comment.
This is the same test case we removed from Go SDK
IBM/platform-services-go-sdk#330 (comment)
swcolley
approved these changes
Mar 19, 2025
Contributor
swcolley
left a comment
swcolley
left a comment
There was a problem hiding this comment.
These changes look good to me.
Contributor
|
Integration tests: mvn ver
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.91 s -- in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[DEBUG] Closing the fork 1 after saying GoodBye.
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:08 min
[INFO] Finished at: 2025-03-19T10:09:15-04:00
[INFO] ------------------------------------------------------------------------ |
Contributor
|
Example test results: mvn exec:java -Dexec.mainClass="com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementExamples"
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36.243 s
[INFO] Finished at: 2025-03-19T10:15:40-04:00
[INFO] ------------------------------------------------------------------------ |
padamstx
approved these changes
Mar 19, 2025
|
|
||
| /* | ||
| * IBM OpenAPI SDK Code Generator Version: 3.90.1-64fd3296-20240515-180710 | ||
| * IBM OpenAPI SDK Code Generator Version: 3.100.0-2ad7a784-20250212-162551 |
Contributor
There was a problem hiding this comment.
In general, it's a good practice to always generate the code with the most recent version of the SDK generator (3.102.0 currently). The version you used is "recent enough", but in the future please use the latest version.
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 21, 2025
# [0.63.0](0.62.0...0.63.0) (2025-03-21) ### Features * **IAM Policy Management:** add access management account settings API ([#267](#267)) ([7d4dbe3](7d4dbe3))
Contributor
|
🎉 This PR is included in version 0.63.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Adds new Access Management Account Settings API (GET and PATCH paths)
Does this PR introduce a breaking change?
Other information
Issue: https://github.ibm.com/IAM/AM-issues/issues/3316