fix(IAM Policy Management): add nested conditions to rule.conditions#228
Merged
fix(IAM Policy Management): add nested conditions to rule.conditions#228
Conversation
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
…n-sdk into policyNestedConditions
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Contributor
Author
|
New tests: pytest test/integration/test_iam_policy_management_v1.py
============================================================================== test session starts ==============================================================================
platform darwin -- Python 3.10.12, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 27 items
test/integration/test_iam_policy_management_v1.py ........................... [100%]
============================================================================== 27 passed in 18.10s ==============================================================================
(venv) shaunsmacibm@Shauns-MacBook-Pro platform-services-python-sdk % pytest examples/test_iam_policy_management_v1_examples.py
============================================================================== test session starts ==============================================================================
platform darwin -- Python 3.10.12, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-python-sdk
plugins: cov-2.12.1
collected 28 items
examples/test_iam_policy_management_v1_examples.py ............................ [100%]
============================================================================== 28 passed in 10.70s ============================================================================== |
padamstx
changed the title
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 7, 2023
## [0.46.1](v0.46.0...v0.46.1) (2023-11-07) ### Bug Fixes * **IAM Policy Management:** add nested conditions to rule.conditions ([#228](#228)) ([aa43c31](aa43c31))
|
🎉 This PR is included in version 0.46.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Updated based on minor api definition update.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
Integration Tests:
Examples: