Skip to content

feat(Account Management): add new service to the project#319

Merged
pyrooka merged 1 commit intoIBM:mainfrom
PureMathematics:add-account-api
Feb 27, 2026
Merged

feat(Account Management): add new service to the project#319
pyrooka merged 1 commit intoIBM:mainfrom
PureMathematics:add-account-api

Conversation

@PureMathematics
Copy link
Contributor

@PureMathematics PureMathematics commented Feb 11, 2026

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No
(venv) ➜  platform-services-python-sdk git:(add-account-api) ✗ pytest -s -v examples/test_account_management_v4_examples.py
=========================================================================================== test session starts ===========================================================================================
platform darwin -- Python 3.9.6, pytest-8.4.2, pluggy-1.6.0 -- /Users/davidlim/IBM-opensource/platform-services-python-sdk/venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/davidlim/IBM-opensource/platform-services-python-sdk
configfile: pyproject.toml
collected 1 item                                                                                                                                                                                          

examples/test_account_management_v4_examples.py::TestAccountManagementV4Examples::test_get_account_example account_management_v4.env
Setup complete.

get_account() result:
{
  "name": "COBIS TOPAZ Enterprise",
  "id": "4904bf0fc13042878784054a1fd0f320",
  "owner": "973aa8c2-6978-43b5-8b08-96060058adca",
  "owner_userid": "jpanizza@incosoluciones.com",
  "owner_iamid": "IBMid-661004T391",
  "type": "SUBSCRIPTION",
  "status": "ACTIVE",
  "linked_softlayer_account": "2755666",
  "team_directory_enabled": true,
  "traits": {
    "eu_supported": false,
    "poc": false,
    "hippa": false
  }
}
PASSED

(venv) ➜  platform-services-python-sdk git:(add-account-api) ✗ pytest -s -v test/integration/test_account_management_v4.py  
=========================================================================================== test session starts ===========================================================================================
platform darwin -- Python 3.9.6, pytest-8.4.2, pluggy-1.6.0 -- /Users/davidlim/IBM-opensource/platform-services-python-sdk/venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/davidlim/IBM-opensource/platform-services-python-sdk
configfile: pyproject.toml
collected 1 item                                                                                                                                                                                          

test/integration/test_account_management_v4.py::TestAccountManagementV4::test_get_account Setup complete.
PASSED

(venv) ➜  platform-services-python-sdk git:(add-account-api) ✗ pytest -s -v test/unit/test_account_management_v4.py
=========================================================================================== test session starts ===========================================================================================
platform darwin -- Python 3.9.6, pytest-8.4.2, pluggy-1.6.0 -- /Users/davidlim/IBM-opensource/platform-services-python-sdk/venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/davidlim/IBM-opensource/platform-services-python-sdk
configfile: pyproject.toml
collected 8 items                                                                                                                                                                                         

test/unit/test_account_management_v4.py::TestNewInstance::test_new_instance PASSED
test/unit/test_account_management_v4.py::TestNewInstance::test_new_instance_without_authenticator PASSED
test/unit/test_account_management_v4.py::TestGetAccount::test_get_account_all_params PASSED
test/unit/test_account_management_v4.py::TestGetAccount::test_get_account_all_params_with_retries PASSED
test/unit/test_account_management_v4.py::TestGetAccount::test_get_account_value_error PASSED
test/unit/test_account_management_v4.py::TestGetAccount::test_get_account_value_error_with_retries PASSED
test/unit/test_account_management_v4.py::TestModel_AccountResponseTraits::test_account_response_traits_serialization PASSED
test/unit/test_account_management_v4.py::TestModel_AccountResponse::test_account_response_serialization PASSED

Other information

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2026

CLA assistant check
All committers have signed the CLA.

@PureMathematics PureMathematics force-pushed the add-account-api branch 4 times, most recently from ee7d447 to ed40d48 Compare February 11, 2026 19:41
Copy link

@rsimsibm2 rsimsibm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pyrooka
Copy link
Member

pyrooka commented Feb 12, 2026

A few things are missing from this PR:

  • Missing unit and integration tests
  • No evidence of a clean test run
  • The code is not formatted, thus the builds fail. Run make lint-fix to address this
  • The README is not updated
  • The PR title should be corrected
  • The CLA hasn't been accepted yet. (Or has it?)

See this PR as a reference: #242

Please address each element from the list above to get the PR merged in.

@PureMathematics PureMathematics force-pushed the add-account-api branch 4 times, most recently from 546e178 to 377ff08 Compare February 25, 2026 19:34
@PureMathematics PureMathematics changed the title add AM v4 api (feat Account Management) add AM v4 api Feb 26, 2026
@PureMathematics PureMathematics force-pushed the add-account-api branch 4 times, most recently from 75e985d to ec85dcb Compare February 26, 2026 19:30
@pyrooka pyrooka self-assigned this Feb 27, 2026
@pyrooka pyrooka self-requested a review February 27, 2026 07:43
@pyrooka pyrooka changed the title (feat Account Management) add AM v4 api feat(Account Management): add new service to the project Feb 27, 2026
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment related to the changes in the README. Otherwise, the PR looks good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid formatting the whole service table and only include the change that adds the new service.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@PureMathematics PureMathematics force-pushed the add-account-api branch 7 times, most recently from 7fe00f0 to 4ad96dd Compare February 27, 2026 15:07
Signed-off-by: David <David.Lim0305@ibm.com>
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyrooka pyrooka merged commit 5bd4c16 into IBM:main Feb 27, 2026
10 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Feb 27, 2026
# [0.74.0](v0.73.3...v0.74.0) (2026-02-27)

### Features

* **Account Management:** add new service to the project ([#319](#319)) ([5bd4c16](5bd4c16))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants