Skip to content

Conversation

@Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 30, 2021

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi self-assigned this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #100 (16aca99) into main (d4e626d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          22       22           
  Lines       20606    20614    +8     
=======================================
+ Hits        19297    19305    +8     
  Misses       1309     1309           
Impacted Files Coverage Δ
ibm_platform_services/iam_access_groups_v2.py 94.66% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e626d...16aca99. Read the comment docs.

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

]
},
"version": "0.13.1+ibm.32.dss",
"version": "0.13.1+ibm.31.dss",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update your copy of detect-secrets :)

@padamstx padamstx merged commit b9cfa6f into main Apr 1, 2021
@padamstx padamstx deleted the update-iam-access-groups branch April 1, 2021 17:27
ibm-devx-automation pushed a commit that referenced this pull request Apr 1, 2021
## [0.18.2](v0.18.1...v0.18.2) (2021-04-01)

### Bug Fixes

* **IAM Access Groups:** update service after recent api changes ([#100](#100)) ([b9cfa6f](b9cfa6f))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants