Skip to content

Conversation

@pyrooka
Copy link
Member

@pyrooka pyrooka commented Mar 5, 2021

PR summary

This PR updates the Resource Manager service and also add examples.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #90 (591d7f4) into main (eaf2915) will increase coverage by 0.01%.
The diff coverage is 94.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   93.57%   93.58%   +0.01%     
==========================================
  Files          21       21              
  Lines       19815    20022     +207     
==========================================
+ Hits        18542    18738     +196     
- Misses       1273     1284      +11     
Impacted Files Coverage Δ
ibm_platform_services/resource_manager_v2.py 94.17% <ø> (ø)
ibm_platform_services/iam_identity_v1.py 93.37% <91.79%> (-0.28%) ⬇️
ibm_platform_services/resource_controller_v2.py 95.96% <100.00%> (+0.20%) ⬆️
ibm_platform_services/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3ecf5...591d7f4. Read the comment docs.

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes needed, similar to the Go PR.

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx self-assigned this Mar 16, 2021
@padamstx padamstx merged commit 4fabb77 into main Mar 18, 2021
@padamstx padamstx deleted the update-rm branch March 18, 2021 14:33
ibm-devx-automation pushed a commit that referenced this pull request Mar 18, 2021
## [0.17.15](v0.17.14...v0.17.15) (2021-03-18)

### Bug Fixes

* **Resource Manager:** update service after recent API changes and generate examples ([#90](#90)) ([4fabb77](4fabb77))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants