This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Add fixed padding option to sentence_embeddings, sentence_indexer #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkornuta-ibm
approved these changes
Apr 26, 2019
|
|
||
| # Create the returned dict. | ||
| data_dict.extend({self.key_outputs: outputs_list}) | ||
|
|
Contributor
There was a problem hiding this comment.
I guess that function should be removed as it is already in utils/word_mappings.py
tkornuta-ibm
suggested changes
Apr 26, 2019
Contributor
tkornuta-ibm
left a comment
tkornuta-ibm
left a comment
There was a problem hiding this comment.
- remove pad_list from sentence_embeddings
- rename the function to pad_truncate_list
|
|
||
| logger.info("Saved mappings of size {} to file '{}'".format(len(word_to_ix), file_path)) | ||
|
|
||
| def pad_list(l: list, length: int, value = 0): |
Contributor
There was a problem hiding this comment.
-
maybe the name should be pad_truncate_list, that will reflect more its behavior?
-
not sure whether word_mappings.py is the right place... but please leave it here for now.
Contributor
Author
There was a problem hiding this comment.
Yeah since the function is used both in SentenceEmbeddings and SentenceIndexer, I though that it should be somewhere in a "utils" collection of static functions.
tkornuta-ibm
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for the attention decoder, as it uses a FC layer that depends on the encoded sequence length.