This repository was archived by the owner on Jul 18, 2024. It is now read-only.
New config to run pipeline with Q-self attention + I-cross attention + MFB pooling #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkornuta-ibm
reviewed
May 6, 2019
| if(self.output_mode == 'Image'): | ||
| # Output attention-weighted image encodings | ||
| outputs = attention_enc_img | ||
| elif(self.output_mode == 'None'): |
Contributor
There was a problem hiding this comment.
I think 'None' is misleading - seems that the component will return something, right...?
Author
There was a problem hiding this comment.
Hey! I fixed this 'output_mode' to take two states: (1) 'Image' --- to return only attention-weighted image, and (2) 'Fusion' -- to return a concatenated output of attention-weighted image and question.
Hope this can be merged now :)
added 2 commits
May 6, 2019 13:49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "output_mode" to VQA_Attention to enable it to switch between returning only the attention-weighted Image or return a concatenated vector of (attn Image + Question).