Skip to content

Comments

fix(authentication): use variables instead of vars[*] when deciding on authentication#14

Merged
germanattanasio merged 1 commit intomasterfrom
fix/auth-from-file
Aug 8, 2019
Merged

fix(authentication): use variables instead of vars[*] when deciding on authentication#14
germanattanasio merged 1 commit intomasterfrom
fix/auth-from-file

Conversation

@mamoonraja
Copy link
Member

@mamoonraja mamoonraja requested a review from mediumTaj August 8, 2019 18:02
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #14 into master will increase coverage by 1.23%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #14      +/-   ##
========================================
+ Coverage   98.76%   100%   +1.23%     
========================================
  Files           7      7              
  Lines         325    326       +1     
========================================
+ Hits          321    326       +5     
+ Misses          4      0       -4
Impacted Files Coverage Δ
lib/ibm_cloud_sdk_core/base_service.rb 100% <100%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1269e...3966353. Read the comment docs.

@germanattanasio germanattanasio merged commit c317303 into master Aug 8, 2019
@germanattanasio germanattanasio deleted the fix/auth-from-file branch August 8, 2019 19:40
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 0.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants