LLM Judge: Improve context/prediction fields parsing #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinscooper
force-pushed
the
improve-context-parsing
branch
2 times, most recently
from
9ed2bc6 to
f21ee3e
Compare
elronbandel
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Well done. Seriously. The only thing I will change is having list creations in a loop for easier debugging and error traces. Especially where you have condition and a loop in the same list.
Additionally, I think we should test the new mode somehow. It's will significantly increase our ability to maintain all the different options to feed context fields and prediction fields.
Lastly is all the documentation aligned with the new option which is the recommended if I understand correctly?
martinscooper
force-pushed
the
improve-context-parsing
branch
3 times, most recently
from
92611c2 to
0399a76
Compare
elronbandel
approved these changes
Jul 8, 2025
martinscooper
force-pushed
the
improve-context-parsing
branch
from
0399a76 to
b5498b3
Compare
martinscooper
force-pushed
the
improve-context-parsing
branch
5 times, most recently
from
8dd81cb to
29f47d4
Compare
|
LGTM |
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: elronbandel <elronbandel@gmail.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
Signed-off-by: Martín Santillán Cooper <msantillancooper@ibm.com>
martinscooper
force-pushed
the
improve-context-parsing
branch
from
29f47d4 to
50e9be6
Compare
oktie
pushed a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.