feat(release): fixed the release, added ci.yml#61
Conversation
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
|
@ujjwal-ibm We have a bunch of default travis environment variables that needs taken care of along with build scripts. Needs migration to actions. |
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
astha-jain
left a comment
astha-jain
left a comment
There was a problem hiding this comment.
Update https://github.com/IBM/vpc-java-sdk/blob/master/build/setMavenVersion.sh and https://github.com/IBM/vpc-java-sdk/blob/master/build/publishJavadoc.sh to change travis secrets relevant to actions.
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
astha-jain
left a comment
astha-jain
left a comment
There was a problem hiding this comment.
I think we'll need to encrypt the keys instead of directly importing private key. This aligns with our previous process as well.
| GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
| OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }} | ||
| OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }} | ||
| GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} |
There was a problem hiding this comment.
I recommend taking a look at https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#storing-large-secrets instead.
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
Signed-off-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
astha-jain
left a comment
astha-jain
left a comment
There was a problem hiding this comment.
Looks good for now and not a blocker for publishing the SDK. I also want to continue researching on encrypting the private key and also want to look for SDK Core's guidance on it.
# [0.23.0](0.22.0...0.23.0) (2025-01-15) ### Features * **release:** fixed ci.yml ([#62](#62)) ([de68af4](de68af4)) * **release:** fixed the release, added ci.yml ([#61](#61)) ([000ebb2](000ebb2)) * **spec:** updated the sdk as per the api spec released on 2024-12-26 ([#60](#60)) ([77c9d37](77c9d37))
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [0.23.0](0.22.0...0.23.0) (2025-01-16) ### Features * cleaned up unwanted changes ([#65](#65)) ([d0aa7ed](d0aa7ed)) * **release:** fixed ci.yml ([#62](#62)) ([de68af4](de68af4)) * **release:** fixed release maven changes ([#63](#63)) ([0a3d31e](0a3d31e)) * **release:** fixed the release, added ci.yml ([#61](#61)) ([000ebb2](000ebb2)) * **spec:** updated the sdk as per the api spec released on 2024-12-26 ([#60](#60)) ([77c9d37](77c9d37))
# [0.23.0](0.22.0...0.23.0) (2025-01-16) ### Features * cleaned up unwanted changes ([#65](#65)) ([d0aa7ed](d0aa7ed)) * **release:** fixed ci.yml ([#62](#62)) ([de68af4](de68af4)) * **release:** fixed mvn versions issue ([#66](#66)) ([e71a131](e71a131)) * **release:** fixed release maven changes ([#63](#63)) ([0a3d31e](0a3d31e)) * **release:** fixed the release, added ci.yml ([#61](#61)) ([000ebb2](000ebb2)) * **spec:** updated the sdk as per the api spec released on 2024-12-26 ([#60](#60)) ([77c9d37](77c9d37))
3 participants
No description provided.