Skip to content

New bug fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New bug fix #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
faf8d05
Update shoppingassistantservice.py
IP10 Aug 11, 2025
1b76a1c
Update shoppingassistantservice.py
IP10 Aug 11, 2025
9ed92b2
Update shoppingassistantservice.py
IP10 Aug 11, 2025
dcee869
Merge branch 'main' into new-bug-fix
IP10 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shoppingassistantservice/shoppingassistantservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ def talkToGemini():
print("Beginning RAG call")
prompt = request.json['message']
prompt = unquote(prompt)

# Step 1 – Get a room description from Gemini-vision-pro
llm_vision = ChatGoogleGenerativeAI(model="gemini-1.5-flash")
message = HumanMessage(
Expand All @@ -93,6 +92,7 @@ def talkToGemini():
print(f"Retrieved documents: {len(docs)}")
#Prepare relevant documents for inclusion in final prompt
relevant_docs = ""
talkTogemini()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Remove the erroneous call to talkTogemini() inside the talkToGemini function to prevent unintended recursion and a NameError. [possible bug]

Suggested change
talkTogemini()
Why this change? The call to `talkTogemini()` inside `talkToGemini` causes unintended recursion and will likely raise a NameError because the function name is mis-cased. Removing this line prevents infinite recursion and runtime errors, while preserving the intended flow of similarity search and document processing.

for doc in docs:
doc_details = doc.to_json()
print(f"Adding relevant document to prompt context: {doc_details}")
Expand Down