fix: change the data type of isReleased to boolean #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
added
bug
ekraffmiller
approved these changes
Sep 19, 2024
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good, approved!
GPortas
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The isReleased is supposed to be boolean, instead of string data type, in order to align with API responses.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
After this work is done we should remove the hardcoded value from the frontend repo in this part of the code.
The isReleased property is correctly treated as a boolean in the frontend repo.
Suggestions on how to test this:
Is there a release notes update needed for this change?:
No
Additional documentation: