Expand CRYOSMS page to de-silo from me #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | FAST_RATE | The ramp rate to use for the fast ramps | 0.5 | | ||
| | FAST_PERSISTENT_SETTLETIME | The number of seconds to settle after a ramp fast to persist | 5 | | ||
| | PERSISTENT_SETTLETIME | The number of seconds to settle after a ramp to persist | 60 | | ||
| | FILTER_VALUE | The value to use to filter the target reached calculation | 0.1 | |
Member
There was a problem hiding this comment.
The value to use to filter the target reached calculation
What does this mean?
| | PERSISTENT_SETTLETIME | The number of seconds to settle after a ramp to persist | 60 | | ||
| | FILTER_VALUE | The value to use to filter the target reached calculation | 0.1 | | ||
| | FAST_FILTER_VALUE | The value to use to filter the target reached calculation when ramping fast to a target | 1 | | ||
| | NPP | The npp value when calculating whether or not the target has been reached | | |
Member
There was a problem hiding this comment.
The npp value
What does this mean?
Tom-Willemsen
deleted the
add-most-of-myundocumented-cryomag-knowledge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that covers it, if you need anything else get in touch.
There are probably formatting errors in this. If you are feeling petty you can tell me to do them when I'm back from thailand, otherwise it will be quicker for somebody else to look at them.