- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
Document key-based auth #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            3 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| # SSH key-based auth | ||
|  | ||
| Instruments run an SSH server, which can be used to execute commands remotely. | ||
|  | ||
| It is possible to access this SSH server using key-based authentication. Keys are associated with | ||
| an individual, but are used to grant access to the instrument accounts. This means that keys | ||
| for individuals no longer on the team can be easily revoked. | ||
|  | ||
| ## Key-pair generation | ||
|  | ||
| :::{note} | ||
| If you already have a suitable SSH key, which is encrypted using a passphrase, you may | ||
| skip this step. | ||
| ::: | ||
|  | ||
| Generate a key-pair using a strong algorithm, for example `ed25519`: | ||
| ``` | ||
| ssh-keygen -t ed25519 | ||
| ``` | ||
| **You must encrypt this key with a strong password when prompted.** | ||
| Don't use an empty passphrase for these keys. This is not a shared | ||
| password, it is a password for your personal key-pair; store it in your password | ||
| manager. This will generate two files: `~\.ssh\id_ed25519` and `~\.ssh\id_ed25519.pub`. The file | ||
| ending in `.pub` is a public key, the one without the `.pub` extension is a private key. It | ||
| would be sensible to store copies of these two files in your password manager too. | ||
|  | ||
| :::{warning} | ||
| For the avoidance of doubt, the **public** key (`*.pub`) can be freely shared with everyone (for | ||
| example, by being copied onto instruments). Do not share your **private** key. The private key | ||
| is additionally encrypted using your selected password. | ||
| ::: | ||
|  | ||
| ## Setting up SSH agent | ||
|  | ||
| In a powershell window, run the following commands: | ||
| ```powershell | ||
| Get-Service ssh-agent | Set-Service -StartupType Automatic | ||
| Start-Service ssh-agent | ||
| ``` | ||
|  | ||
| ## Deploying the public key | ||
|  | ||
| - Add your public key to the [keys repository](https://github.com/ISISComputingGroup/keys). | ||
| - Ask a developer whose key is *already* deployed to run the [`deploy_keys.py` script](https://github.com/ISISComputingGroup/keys/blob/main/deploy_keys.py), which will | ||
| update the `authorized_keys` files on each instrument. | ||
|  | ||
| If the permissions on `administrators_authorized_keys` are wrong, that file won't work. The | ||
| permissions can be fixed by running: | ||
|  | ||
| ``` | ||
| icacls.exe "c:\ProgramData\ssh\administrators_authorized_keys" /inheritance:r /grant "Administrators:F" /grant "SYSTEM:F" | ||
| ``` | ||
|  | ||
| ## One-off usage | ||
|  | ||
| To connect via SSH to an instrument, use: | ||
|  | ||
| ``` | ||
| ssh spudulike@NDXINST | ||
| ``` | ||
|  | ||
| This will prompt you on each connection for the passphrase to unlock your SSH key, this is the | ||
| password you set earlier for your personal SSH key. You will not be prompted for an | ||
| account password; your key is sufficient to grant you access. | ||
|  | ||
| ## Bulk usage | ||
|  | ||
| :::{caution} | ||
| If you intend to run a command across many instruments, it is worth getting that command | ||
| reviewed by another developer and running it together. This is **especially** true if you intend to | ||
| run a command as a privileged user. | ||
| ::: | ||
|  | ||
| Typing the password to unlock your SSH key for each instrument would be tedious. | ||
| To avoid this, we can **temporarily** add the key to the SSH agent: | ||
|  | ||
| ``` | ||
| ssh-add | ||
| ``` | ||
| This will prompt for the passphrase to unlock your SSH key. You can check that your key is now in | ||
| the SSH agent by running: | ||
|  | ||
| ``` | ||
| ssh-add -l | ||
| ``` | ||
|  | ||
| Once the key has been added to the agent, you can SSH to an instrument without any further prompts: | ||
|  | ||
| ``` | ||
| ssh spudulike@NDXINST | ||
| ``` | ||
|  | ||
| Commands can be executed like: | ||
|  | ||
| ``` | ||
| ssh spudulike@NDXINST "dir /?" | ||
| ``` | ||
|  | ||
| Since we no longer have any authentication prompts (having added our key to the SSH-agent), | ||
| this command is suitable for automating in a loop over instruments - for example from python | ||
| or a `.bat` script. | ||
|  | ||
| Once you have finished with the administration task which needed SSH across multiple instruments, you | ||
| should remove your key from the agent (and then verify that it has been removed): | ||
|  | ||
| ``` | ||
| ssh-add -D | ||
| ssh-add -l | ||
| ``` | ||
|  | ||
| :::{important} | ||
| Do not leave these keys permanently added to the SSH agent - having *immediate* SSH access to *every* | ||
| instrument is an unnecessary risk most of the time (for example if your developer machine was compromised). | ||
| Add the keys to the SSH agent only when needed, and remove them from the agent again when your administration | ||
| task is complete. The usual sudo lecture applies: | ||
| > We trust you have received the usual lecture from the local System | ||
| > Administrator. It usually boils down to these three things: | ||
| > 1) Respect the privacy of others. | ||
| > 2) Think before you type. | ||
| > 3) With great power comes great responsibility. | ||
| ::: | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this in a warning/caution admonitiion i'd say.