Skip to content

Conversation

@John-Holt-Tessella
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella commented Sep 8, 2017

Description of work

Enable you to drag and drop in the synoptic editor. There is no supporting code and this is not the right way to do it. There will be a follow up that will fix this including rcptt tests.

To test

ISISComputingGroup/IBEX#2563

Acceptance criteria

  1. Can drag and drop synoptic components in the tree view.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Have no new checkstyle warnings been introduced? Check via Jenkins
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Are there automated system tests in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?
  • Has the manual system tests spreadsheet been updated?
    • Manual system tests for the functionality should be added if there are no automated tests
    • Manual system tests can be removed from the template if they are covered by suitable automated tests
  • Did any existing system test break as a result of the current changes?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?
  • If an OPI has been modified, does it conform to the style guidelines? There is a script called check_opi_format.py to help with this.

Functional Tests

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Tom-Willemsen Tom-Willemsen merged commit 40dba24 into master Sep 8, 2017
@Tom-Willemsen Tom-Willemsen deleted the Ticket2563_synoptics_drag_and_drop branch September 8, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants