-
Notifications
You must be signed in to change notification settings - Fork 0
Increase timeout and update configs #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tom-Willemsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge if you want, but a couple of small typing suggestions
|
|
||
|
|
||
| def parameterized_list(cases): | ||
| def parameterized_list(cases: list[Any]) -> list[tuple[str, Any]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future I think this could be typed as:
T = TypeVar("T")
def parameterized_list(cases: list[T]) -> list[tuple[str, T]]:
or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if T is a tuple then i think it is slightly different as in
parameterized_list([(1,2)]) -> "(1,2)", 1, 2 as opposed to "(1,2)", (1,2)
so T is unpacked ... so is that potentially tuple[str, Any, ...] ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... that case can probably be done with typing.overload and typing.Unpack, but happy enough with Any for the moment then (and since this is only really used by tests, maybe not worth going too overboard with it)
Description of work
Increase config load timeout for large memory test config
Ticket
Link to Ticket
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps