Skip to content

Conversation

@FreddieAkeroyd
Copy link
Member

Description of work

Increase config load timeout for large memory test config

Ticket

Link to Ticket

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@pull-request-size pull-request-size bot added size/L and removed size/S labels Mar 31, 2025
@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Apr 1, 2025
Copy link
Member

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge if you want, but a couple of small typing suggestions



def parameterized_list(cases):
def parameterized_list(cases: list[Any]) -> list[tuple[str, Any]]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future I think this could be typed as:

T = TypeVar("T")

def parameterized_list(cases: list[T]) -> list[tuple[str, T]]:

or similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if T is a tuple then i think it is slightly different as in

parameterized_list([(1,2)]) -> "(1,2)", 1, 2 as opposed to "(1,2)", (1,2)

so T is unpacked ... so is that potentially tuple[str, Any, ...] ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see... that case can probably be done with typing.overload and typing.Unpack, but happy enough with Any for the moment then (and since this is only really used by tests, maybe not worth going too overboard with it)

@Tom-Willemsen Tom-Willemsen merged commit d9f2d85 into master Apr 2, 2025
4 checks passed
@Tom-Willemsen Tom-Willemsen removed this from Tasks Apr 2, 2025
@FreddieAkeroyd FreddieAkeroyd deleted the increase_memory_load_timeout branch June 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants