Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 26, 2020

What do these changes do?

There was a bit a of a race condition when setting the lock to a study-card after closing the study, specially when running in not so powerful machines. This PR wants to fix that. Let's see.

e2e: Check study state before deleting

Related issue number

related to #1987

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Nov 26, 2020
@odeimaiz odeimaiz self-assigned this Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2004 (8807f25) into master (9ff3024) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2004     +/-   ##
========================================
- Coverage    73.7%   73.7%   -0.1%     
========================================
  Files         385     385             
  Lines       14210   14210             
  Branches     1434    1434             
========================================
- Hits        10480   10479      -1     
  Misses       3351    3351             
- Partials      379     380      +1     
Flag Coverage Δ
integrationtests 63.0% <ø> (-0.1%) ⬇️
unittests 67.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 88.7% <0.0%> (-2.3%) ⬇️
.../director/src/simcore_service_director/producer.py 61.1% <0.0%> (+0.2%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review November 26, 2020 16:20
@odeimaiz odeimaiz changed the title e2e: Check study state before deleting Improve closing study workflow Nov 26, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Nov 26, 2020
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@odeimaiz odeimaiz requested a review from pcrespov November 26, 2020 17:38
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@odeimaiz odeimaiz merged commit 78a332e into ITISFoundation:master Nov 27, 2020
@odeimaiz odeimaiz added this to the Alfred_Büchi milestone Nov 27, 2020
@sanderegg sanderegg mentioned this pull request Dec 17, 2020
@odeimaiz odeimaiz deleted the e2e/check-state-before-deleting branch February 24, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants