-
Notifications
You must be signed in to change notification settings - Fork 32
Improve closing study workflow #2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve closing study workflow #2004
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
========================================
- Coverage 73.7% 73.7% -0.1%
========================================
Files 385 385
Lines 14210 14210
Branches 1434 1434
========================================
- Hits 10480 10479 -1
Misses 3351 3351
- Partials 379 380 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
What do these changes do?
There was a bit a of a race condition when setting the lock to a study-card after closing the study, specially when running in not so powerful machines. This PR wants to fix that. Let's see.
e2e: Check study state before deleting
Related issue number
related to #1987
How to test
Checklist
make openapi-specs,git commit ...and thenmake version-*)