Zoom Pipeline editor in/out/reset

[odeimaiz]

What do these changes do?

• A zoom feature that zooms only in the study window, and doesn't just increase the size of everything on the page.

Bonus:

• e2e: One more try to get rid of the lock on the jupyters study
• bug fixed: "Delete" and "Esc" commands were always active

Toolbar:

Related issue number

closes ITISFoundation/osparc-issues#253
realted to ITISFoundation/osparc-issues#368

How to test

Checklist

• Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes
• New module? Add your github username to .github/CODEOWNERS

[codecov]

Codecov Report

Merging #2006 (4ac6f79) into master (c2062a7) will increase coverage by 1.6%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2006     +/-   ##
========================================
+ Coverage    72.0%   73.7%   +1.6%     
========================================
  Files         390     390             
  Lines       14346   14346             
  Branches     1441    1441             
========================================
+ Hits        10335   10577    +242     
+ Misses       3650    3383    -267     
- Partials      361     386     +25     

Flag	Coverage Δ
integrationtests	63.2% <ø> (+<0.1%)	⬆️
unittests	67.7% <ø> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...webserver/computation_comp_tasks_listening_task.py	86.6% <0.0%> (-3.4%)	⬇️
.../director/src/simcore_service_director/producer.py	60.6% <0.0%> (-0.5%)	⬇️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py	89.7% <0.0%> (+4.4%)	⬆️
.../sidecar/src/simcore_service_sidecar/log_parser.py	81.8% <0.0%> (+16.8%)	⬆️
...ervices/sidecar/src/simcore_service_sidecar/cli.py	65.8% <0.0%> (+19.5%)	⬆️
...vices/sidecar/src/simcore_service_sidecar/utils.py	80.7% <0.0%> (+29.4%)	⬆️
services/sidecar/src/simcore_service_sidecar/db.py	92.0% <0.0%> (+40.0%)	⬆️
...rvices/sidecar/src/simcore_service_sidecar/core.py	71.4% <0.0%> (+46.6%)	⬆️
...es/sidecar/src/simcore_service_sidecar/executor.py	79.6% <0.0%> (+56.1%)	⬆️

[KZzizzle]

nice

[sanderegg]

pretty cool!!
what happens if I unzoom, move away and lose my workbench? can I "zoom all"?

[GitHK]

This is OKish but I would ask for the following:

• if you are using a trackpad the zoom is way too fast (don't know how to fix), but a button to reset to the original coordinates would be good
• drag with center mouse button pressed.

Image showing how hard it is to use with the trackpad. I was zooming super slowly.

[odeimaiz]

This is OKish but I would ask for the following:

• if you are using a trackpad the zoom is way too fast (don't know how to fix), but a button to reset to the original coordinates would be good
• drag with center mouse button pressed.

Image showing how hard it is to use with the trackpad. I was zooming super slowly.

• I would need your trackpad to see how the event looks like or you PR the extension. Adding the zoom in/out, reset to original and zoom all buttons is also an option.

• If you want to move around the workbench you have the scroll bar. If you also want that center mouse button feature, we can implement it in the next iteration, create an issue, please.

[odeimaiz]

pretty cool!!
what happens if I unzoom, move away and lose my workbench? can I "zoom all"?

When zooming in and out, the position of the nodes is taken into account, so I don't think you can actually lose the workbench. I will implement the "zoom all" button.

[GitHK]

Added issue to keep track of dragging #2016

[ignapas]

This is super cool.
I just saw that the unlink button disappears when you zoom in, and that the scroll bars act weird when you zoom out. If you zoom out and everything is visible, there shouldn't be any scroll bar right? In fact, they don't do anything.
I think it would be cool to implement the suggested features for this first iteration:

• zoom in and zoom out buttons for users without a mouse wheel
• zoom all that adjusts zoom to have the whole workbench in the view

Something like in GoogleMaps (the button at the top would be the 'zoom all' feature). And the unlink button would appear/disappear on top, too.

[KZzizzle]

I haven't managed to run this on my computer yet and so haven't really "tested". If you think it makes sense, I would also make the zoom ability triggered with holding down shift since that is the behavior of a lot of other apps. Users may try to scroll (even though we don't have that implemented yet) and it could be distracting if the thing zooms. Additionally I see that you now have scroll bars when you are zoomed in. If you have the shift implemented, then scrolling can be left to the intuitive function which is scrolling down within the workbench window

Anyway AWESOME ODEI!!!

[KZzizzle]

I noticed something in zoomed in view and perhaps this is a separate issue - if you try to create a new service dragging from the out port of a service, the catalog will appear outside of the viewable space (in the extreme case you cannot see it at all). You tell me if you want me to put this as a separate issue =)

[odeimaiz]

I haven't managed to run this on my computer yet and so haven't really "tested". If you think it makes sense, I would also make the zoom ability triggered with holding down shift since that is the behavior of a lot of other apps. Users may try to scroll (even though we don't have that implemented yet) and it could be distracting if the thing zooms. Additionally I see that you now have scroll bars when you are zoomed in. If you have the shift implemented, then scrolling can be left to the intuitive function which is scrolling down within the workbench window

Anyway AWESOME ODEI!!!

That one could be addressed here #2016

[odeimaiz]

I noticed something in zoomed in view and perhaps this is a separate issue - if you try to create a new service dragging from the out port of a service, the catalog will appear outside of the viewable space (in the extreme case you cannot see it at all). You tell me if you want me to put this as a separate issue =)

That has always been the case, I can try forcing the catalog to be always completely visible.

[KZzizzle]

Super cool!