Skip to content

Report errors during user cleanup #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 4, 2020
Merged

Report errors during user cleanup #2013

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a427017
GC will shuffle data before emoving it
Dec 1, 2020
e749338
trying to unstuck CI
Dec 1, 2020
b4188e1
reverting
Dec 1, 2020
a2e1b73
Merge branch 'master' into enhancement-gc-shuffles-before-removing
GitHK Dec 2, 2020
b522873
Merge branch 'master' into enhancement-gc-shuffles-before-removing
GitHK Dec 3, 2020
a214a6d
instead of shuffling the error is trapped and logged
Dec 3, 2020
31414d7
removing unused import
Dec 3, 2020
5beda2f
Merge branch 'master' into enhancement-gc-shuffles-before-removing
GitHK Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions services/web/server/src/simcore_service_webserver/resource_manager/garbage_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,15 @@ async def remove_guest_user_with_all_its_resources(
logger.debug("User is not GUEST, skipping cleanup")
return

await remove_all_projects_for_user(app=app, user_id=user_id)
await remove_user(app=app, user_id=user_id)
try:
await remove_all_projects_for_user(app=app, user_id=user_id)
await remove_user(app=app, user_id=user_id)
except Exception as e: # pylint: disable=broad-except
logger.warning("%s", e)
logger.warning(
"Could not remove GUEST with id=%s. Check the logs above for details",
user_id,
)


async def remove_all_projects_for_user(app: web.Application, user_id: int) -> None:
Expand Down