Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 1, 2020

What do these changes do?

  • director-v2 returns a 500 because a container was not stopped properly.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@sanderegg sanderegg changed the title fix checking function generating an retry exception and it should not bugfix director-v2 returns 500 when deleting pipeline that is in undefined state Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2014 (8db1e82) into master (42c5b20) will decrease coverage by 6.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2014     +/-   ##
========================================
- Coverage    73.7%   67.7%   -6.1%     
========================================
  Files         390     390             
  Lines       14344   14344             
  Branches     1441    1441             
========================================
- Hits        10579    9715    -864     
- Misses       3379    4277    +898     
+ Partials      386     352     -34     
Flag Coverage Δ
integrationtests 72.3% <100.0%> (+9.0%) ⬆️
unittests 63.3% <100.0%> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/api/routes/computations.py 89.2% <100.0%> (ø)
...er/src/simcore_service_webserver/storage_routes.py 20.0% <0.0%> (-80.0%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.2% <0.0%> (-64.5%) ⬇️
...simcore_service_webserver/computation_subscribe.py 30.0% <0.0%> (-61.3%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 27.9% <0.0%> (-59.9%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 36.7% <0.0%> (-55.9%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 32.2% <0.0%> (-54.5%) ⬇️
...c/simcore_service_webserver/users_to_groups_api.py 46.1% <0.0%> (-53.9%) ⬇️
...eb/server/src/simcore_service_webserver/statics.py 39.3% <0.0%> (-49.2%) ⬇️
...vice_webserver/studies_dispatcher/handlers_rest.py 52.0% <0.0%> (-48.0%) ⬇️
... and 46 more

@sanderegg sanderegg merged commit 62240c2 into ITISFoundation:master Dec 1, 2020
@sanderegg sanderegg deleted the bugfix/direct_v2_retry_error branch December 1, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants