-
Notifications
You must be signed in to change notification settings - Fork 32
Adding snapshot link to graylog with every call to screenshots #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding snapshot link to graylog with every call to screenshots #2015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
========================================
+ Coverage 70.4% 73.7% +3.2%
========================================
Files 390 390
Lines 14346 14346
Branches 1441 1441
========================================
+ Hits 10109 10579 +470
+ Misses 3885 3382 -503
- Partials 352 385 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :) only a couple of comments... and that annoying linter of yours!
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
What do these changes do?
After the informative presentation by @odeimaiz about end-to-end testing, I felt that during the testing there was little information about the backend state. Then, I thought it might be good to have a way to get a direct link to the backend logs at a give time.
This implements a simple utility function to build links to graylog with a given time spam. Then, this function is used to build a log message next to every call to screenshot that will allow the tester to analyze the backend state corresponding to every front-end screenshot
Added some extra doc.
Related issue number
How to test
Following the instructions of the presentation, we can run a tutorial and see the
Backend Snapshot: ...link next to the screenshotChecklist
make openapi-specs,git commit ...and thenmake version-*)