-
Notifications
You must be signed in to change notification settings - Fork 32
Guided mode/partial pipelines (backend only) #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guided mode/partial pipelines (backend only) #2040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
========================================
+ Coverage 71.7% 73.2% +1.4%
========================================
Files 413 414 +1
Lines 15097 15146 +49
Branches 1526 1540 +14
========================================
+ Hits 10839 11100 +261
+ Misses 3889 3650 -239
- Partials 369 396 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0771d58 to
34a8a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one very very late suggestion.
services/director-v2/src/simcore_service_director_v2/models/domains/comp_tasks.py
Show resolved
Hide resolved
| # FIXME: here we should check if the current inputs are the ones used to generate the current outputs | ||
| # this could be done by saving the inputs as metadata together with the outputs (see blockchain) | ||
| # we should compare the current inputs with the inputs used for generating the current outputs!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you'd like to add a check where if the inputs did not change, there is no need to compute the results again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minors. very nice work!
services/director-v2/src/simcore_service_director_v2/api/routes/computations.py
Show resolved
Hide resolved
| else RunningState.NOT_STARTED, | ||
| pipeline=nx.to_dict_of_lists(dag_graph), | ||
| url=f"{request.url}/{job.project_id}", | ||
| stop_url=f"{request.url}/{job.project_id}:stop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I know this is not from this PR but for reverse urls lookups, it is safer to use https://www.starlette.io/routing/#reverse-url-lookups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. will think about it next time cause I'm not too sure how to use it here.
c799107 to
4e93ff2
Compare
What do these changes do?
allow running partial pipelines as required by the guided mode
Changes:
Director-v2:
subgraphfield which is a list of nodes to be rundirtyand will re-trigger any node that depend on itWebserver
subgraphfield that is forwarded to director-v2NOTE: The frontend will come in a next PR by @odeimaiz
Related issue number
How to test
but the idea is:
now the UI just need to say:
the UI can also say:
Checklist
make openapi-specs,git commit ...and thenmake version-*)