Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 14, 2022

What do these changes do?

  • Selected link goes yellow
  • Wider hover link area

DeleteCurve

Related issue/s

closes ITISFoundation/osparc-issues#581

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jan 14, 2022
@odeimaiz odeimaiz self-assigned this Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2743 (4f1cbba) into master (99b8022) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2743   +/-   ##
======================================
  Coverage    78.3%   78.3%           
======================================
  Files         677     677           
  Lines       27011   27011           
  Branches     2617    2617           
======================================
+ Hits        21154   21158    +4     
  Misses       5144    5144           
+ Partials      713     709    -4     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 74.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_director_v2/modules/dask_client.py 81.5% <0.0%> (-0.7%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 73.5% <0.0%> (+0.8%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.7% <0.0%> (+1.0%) ⬆️
...ore_service_director_v2/api/routes/computations.py 80.3% <0.0%> (+1.7%) ⬆️

@odeimaiz odeimaiz changed the title WIP: Delete link UI/UX Delete link UI/UX Jan 14, 2022
@odeimaiz odeimaiz marked this pull request as ready for review January 14, 2022 16:37
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement in usability!
This also solves the issue of "delete link" button disappearing ? (as it is also part of ITISFoundation/osparc-issues#581 but you did not wrote anything about it in the description above)

@odeimaiz
Copy link
Member Author

Great improvement in usability! This also solves the issue of "delete link" button disappearing ? (as it is also part of ITISFoundation/osparc-issues#581 but you did not wrote anything about it in the description above)

I was not able to reproduce it, but, apparently, the "Delete" shortcut key support is sufficient.

@pcrespov pcrespov added this to the Rudolph milestone Jan 15, 2022
@odeimaiz odeimaiz merged commit b70f404 into ITISFoundation:master Jan 15, 2022
@odeimaiz odeimaiz deleted the feature/delete-link branch January 15, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete key for arrows doesnt work

3 participants