Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

  • the dask clients pool was reporting invalid errors with a valid cause in the client, thus generating confusion
  • the traceback of the error was missing making it difficult to narrow down the issue

This PR shall help in fixing this.

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the R.Schumann milestone Feb 18, 2022
@sanderegg sanderegg self-assigned this Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #2842 (7832ba5) into master (0e9a59a) will decrease coverage by 0.1%.
The diff coverage is 42.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2842     +/-   ##
========================================
- Coverage    78.8%   78.7%   -0.2%     
========================================
  Files         674     674             
  Lines       27356   27352      -4     
  Branches     3185    3182      -3     
========================================
- Hits        21573   21537     -36     
- Misses       5023    5051     +28     
- Partials      760     764      +4     
Flag Coverage Δ
integrationtests 65.7% <42.8%> (-0.1%) ⬇️
unittests 74.3% <42.8%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <33.3%> (+2.2%) ⬆️
...rector_v2/modules/comp_scheduler/base_scheduler.py 83.3% <100.0%> (+0.1%) ⬆️
...vice_director_v2/modules/dynamic_sidecar/errors.py 82.6% <0.0%> (-17.4%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 68.0% <0.0%> (-13.9%) ⬇️
...imcore_service_catalog/db/repositories/projects.py 41.6% <0.0%> (-12.5%) ⬇️
...ore_service_director_v2/api/routes/computations.py 80.1% <0.0%> (-2.6%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 93.1% <0.0%> (-1.8%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 80.7% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-1.3%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 89.6% <0.0%> (-1.1%) ⬇️
... and 2 more

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

else:
try:
yield dask_client
except (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now every other exception is just "let-go" ... who is handling it then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the scheduler

@sanderegg sanderegg merged commit d7b614e into ITISFoundation:master Feb 20, 2022
@sanderegg sanderegg deleted the enhancement/improve_dask_error_logging branch February 20, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants