-
Notifications
You must be signed in to change notification settings - Fork 32
♻️✨ Improve logging output in case of error when scheduling tasks #2842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️✨ Improve logging output in case of error when scheduling tasks #2842
Conversation
… if the exception demands it.
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
========================================
- Coverage 78.8% 78.7% -0.2%
========================================
Files 674 674
Lines 27356 27352 -4
Branches 3185 3182 -3
========================================
- Hits 21573 21537 -36
- Misses 5023 5051 +28
- Partials 760 764 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/base_scheduler.py
Outdated
Show resolved
Hide resolved
| else: | ||
| try: | ||
| yield dask_client | ||
| except ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so now every other exception is just "let-go" ... who is handling it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the scheduler
What do these changes do?
This PR shall help in fixing this.
Related issue/s
How to test
Checklist