Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 18, 2023

What do these changes do?

enable mypy in simcore-sdk

@pcrespov I need your help for this one:

Using mypy 1.2.0 (compiled: yes)
Mypy config /home/sanderegg/dev/github/osparc-simcore/mypy.ini
Mypying /home/sanderegg/dev/github/osparc-simcore/packages/simcore-sdk/src:
src/simcore_sdk/node_ports_v2/nodeports_v2.py:180:49: error: Argument "model" to "ValidationError" has incompatible type "Nodeports"; expected "Union[Type[BaseModel], Type[Dataclass]]"  [arg-type]
Found 1 error in 1 file (checked 24 source files)

fixed.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Apr 18, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 18, 2023
@sanderegg sanderegg self-assigned this Apr 18, 2023
@sanderegg sanderegg marked this pull request as ready for review April 18, 2023 21:22
@sanderegg sanderegg requested a review from GitHK April 18, 2023 21:23
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4138 (a3bd8fb) into master (12763d6) will increase coverage by 1.4%.
The diff coverage is 88.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4138     +/-   ##
========================================
+ Coverage    85.0%   86.4%   +1.4%     
========================================
  Files         954     710    -244     
  Lines       41294   32630   -8664     
  Branches      946     173    -773     
========================================
- Hits        35110   28202   -6908     
+ Misses       5967    4380   -1587     
+ Partials      217      48    -169     
Flag Coverage Δ
integrationtests 67.3% <75.0%> (+0.3%) ⬆️
unittests 82.4% <81.5%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py 68.9% <66.6%> (-1.7%) ⬇️
.../src/simcore_sdk/node_ports_v2/serialization_v2.py 85.9% <80.0%> (+0.2%) ⬆️
.../simcore-sdk/src/simcore_sdk/node_ports_v2/port.py 79.4% <82.6%> (-1.2%) ⬇️
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py 93.0% <87.5%> (-0.1%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 83.5% <100.0%> (-0.3%) ⬇️
...re_sdk/node_ports_common/client_session_manager.py 100.0% <100.0%> (ø)
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 86.1% <100.0%> (-0.2%) ⬇️
...src/simcore_sdk/node_ports_common/file_io_utils.py 88.1% <100.0%> (-0.1%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 81.5% <100.0%> (+0.1%) ⬆️
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py 96.2% <100.0%> (+<0.1%) ⬆️
... and 4 more

... and 253 files with indirect coverage changes

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the maintenance/mypy_simcore_sdk branch from dd70f35 to 008cd3d Compare April 19, 2023 06:28
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the maintenance/mypy_simcore_sdk branch from 7976550 to f3a8e7d Compare April 19, 2023 11:35
@sanderegg sanderegg force-pushed the maintenance/mypy_simcore_sdk branch from f3a8e7d to 6e72d9f Compare April 19, 2023 13:01
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🎉 Greatly appreciated!

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit a3bd8fb and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 18555e5 into ITISFoundation:master Apr 24, 2023
@sanderegg sanderegg deleted the maintenance/mypy_simcore_sdk branch April 24, 2023 07:17
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants