Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented May 11, 2023

What do these changes do?

  • make database migration a module scoped fixture in webserver (gains are in minutes), potential to go for session scoped
  • prepare SQLAlchemy 2.0 migration by fixing test warnings (reference)
    • among others now: sa.select() takes positional arguments, not a list anymore!

BEFORE:
[unit]webserver-01
image
[unit]webserver-02
image
[unit]webserver-03
image

AFTER:
[unit]webserver-01 - 2 minutes gain
image
[unit]webserver-02 - 9 minutes gain
image
[unit]webserver-03 - 4 minutes gain
image

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg self-assigned this May 11, 2023
@sanderegg sanderegg added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 11, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 11, 2023
@sanderegg sanderegg force-pushed the maintenance/no-pg-downgrade-module branch from b6d4d5b to d09d9c2 Compare May 11, 2023 06:52
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #4222 (20bf0e8) into master (65e6eb8) will decrease coverage by 3.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4222     +/-   ##
========================================
- Coverage    84.7%   81.8%   -3.0%     
========================================
  Files         882     838     -44     
  Lines       37503   35251   -2252     
  Branches      953     953             
========================================
- Hits        31786   28845   -2941     
- Misses       5499    6202    +703     
+ Partials      218     204     -14     
Flag Coverage Δ
integrationtests ?
unittests 81.8% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rver/src/simcore_service_webserver/products/_db.py 76.6% <ø> (ø)
...mcore_service_webserver/security/_authorization.py 94.8% <ø> (ø)
...se/src/simcore_postgres_database/utils_products.py 87.5% <100.0%> (ø)
...tabase/src/simcore_postgres_database/utils_tags.py 94.5% <100.0%> (ø)
...server/src/simcore_service_webserver/groups_api.py 93.6% <100.0%> (-2.4%) ⬇️
...re_service_webserver/projects/projects_db_utils.py 97.0% <100.0%> (ø)
.../server/src/simcore_service_webserver/users_api.py 93.0% <100.0%> (-3.5%) ⬇️

... and 236 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/no-pg-downgrade-module branch from d09d9c2 to 25e8a83 Compare May 11, 2023 08:28
@sanderegg sanderegg marked this pull request as ready for review May 11, 2023 10:19
@sanderegg sanderegg requested review from GitHK and pcrespov as code owners May 11, 2023 10:19
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨

@sanderegg sanderegg force-pushed the maintenance/no-pg-downgrade-module branch from 25c4f0c to 20bf0e8 Compare May 11, 2023 11:34
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 20bf0e8 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot! I will keep an eye in the upgrade warnings as well

@sanderegg sanderegg enabled auto-merge (squash) May 11, 2023 11:47
@sanderegg sanderegg disabled auto-merge May 11, 2023 11:53
@sanderegg sanderegg merged commit 5b4b9b3 into ITISFoundation:master May 11, 2023
@sanderegg sanderegg deleted the maintenance/no-pg-downgrade-module branch May 11, 2023 11:53
@GitHK
Copy link
Contributor

GitHK commented May 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants