Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 20, 2023

What do these changes do?

  • 🐛 Fixes file-only study dispatching
    • reserved to registered users, i.e. anonymous get an unauthenticated error message
  • adds more tests
  • ♻️ small cleanup

Related issue/s

How to test

make devenv
source .venv/bin/activate
cd services/web/server
make install-dev
pytest -vv unit/with_dbs/01/studies_dispatcher/test_studies_dispatcher_handlers.py

Manual

  • @ignapas let's check with a new https://osparc-master.speag.com/view?download_link= ... when it hits master

DevOps

None

@pcrespov pcrespov self-assigned this Jun 20, 2023
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs changelog:🐛bugfix labels Jun 20, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #4387 (adda14d) into master (20a1b6b) will increase coverage by 7.5%.
The diff coverage is 83.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4387     +/-   ##
========================================
+ Coverage    76.8%   84.3%   +7.5%     
========================================
  Files         552     393    -159     
  Lines       26734   20516   -6218     
  Branches      359     173    -186     
========================================
- Hits        20543   17314   -3229     
+ Misses       6099    3153   -2946     
+ Partials       92      49     -43     
Flag Coverage Δ
integrationtests 67.9% <0.0%> (-0.2%) ⬇️
unittests 86.3% <83.3%> (+14.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ice_webserver/studies_dispatcher/_rest_handlers.py 91.7% <50.0%> (+30.1%) ⬆️
...ebserver/studies_dispatcher/_redirects_handlers.py 86.6% <100.0%> (+37.5%) ⬆️
...ore_service_webserver/studies_dispatcher/_users.py 95.5% <100.0%> (+52.2%) ⬆️

... and 294 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4342/fix-file-dispatch branch from e4993ce to 6ec9db8 Compare June 20, 2023 12:34
@pcrespov pcrespov marked this pull request as ready for review June 20, 2023 12:34
@pcrespov pcrespov changed the title WIP: 🐛 Is4342/fix file dispatch 🐛 Fixes file-only study dispatcher Jun 20, 2023
@pcrespov pcrespov requested review from elisabettai and ignapas June 20, 2023 12:37
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reconsider the renaming of guest --> anonymous. it is confusing, at least for me.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit adda14d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov enabled auto-merge (squash) June 20, 2023 16:01
@pcrespov pcrespov merged commit 1db71f9 into ITISFoundation:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

front-end view page cannot render only a study with a single file-picker

4 participants