🎨 Payments-methods logic in payments service

[pcrespov]

What do these changes do?

Implements payment-methods logic in the payments service. The logic has been basically copied and adapted from that existing in the webserver.payments plugin. Nonetheless, the code in the webserver will still fake the payment-method until app-motion's app-gateway fully implements the payment-method infrastructure (https://github.com/ITISFoundation/appmotion-exchange/issues/11)

Highlights

• ✨db/payments_methods_repo: implemented a repository layer for payment-methods
• ✨api/rest/_acknowledgements : implemented the rest interface to ACK payment-methods
• ✨api/rpc/_payments_methods : implements rpc interface for payment-methods exposed to the web-server
• ✨services/payments_gateway : implements the http client calls to the payment-gateway API for payment-methods
• ♻️ minor models rename, tests etc

Related issue/s

• Moves logic to payment service in Payments methods: add, remove, list and auto-recharge #4751

How to test

Driving tests

cd services/payments
make install-dev
pytest -vv tests/unit

DevOps

• None

[codecov]

Codecov Report

Merging #4953 (e41d48a) into master (46c1253) will decrease coverage by 4.2%.
The diff coverage is 83.3%.

@@           Coverage Diff            @@
##           master   #4953     +/-   ##
========================================
- Coverage    83.3%   79.1%   -4.2%     
========================================
  Files        1214    1020    -194     
  Lines       50379   42655   -7724     
  Branches     1076     836    -240     
========================================
- Hits        41968   33745   -8223     
- Misses       8184    8726    +542     
+ Partials      227     184     -43     

Flag	Coverage Δ
integrationtests	65.1% <16.6%> (?)
unittests	79.0% <83.3%> (-4.4%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...simcore_service_webserver/payments/_methods_api.py	100.0% <100.0%> (ø)
...simcore_service_webserver/payments/_onetime_api.py	100.0% <100.0%> (ø)
...re_service_webserver/wallets/_payments_handlers.py	99.1% <100.0%> (ø)
...ver/src/simcore_service_webserver/payments/_rpc.py	81.2% <50.0%> (ø)

... and 424 files with indirect coverage changes

[sanderegg]

this is looking good. I am not sure I understand how you distringuish between log.debug messages, todos and fixme though.

[GitHK]

👍

[bisgaard-itis]

Nice! Looks good to me

[qlty-cloud-legacy]

Code Climate has analyzed commit e41d48a and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication

[matusdrobuliak66]

🥇