Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2023

What do these changes do?

disable override of resources with hardware info, as this fails with dynamic services

Following issues were discovered:

  • in non-AWS billable (master): there is no clusters-keeper available and this prevents starting any service
  • in AWS billable: there is currently an issue when starting a dynamic service

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg self-assigned this Nov 1, 2023
@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 1, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fingers crossed

@codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4967 (c52bbc1) into master (d1fd4da) will decrease coverage by 20.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4967      +/-   ##
=========================================
- Coverage    86.9%   66.9%   -20.0%     
=========================================
  Files        1214     508     -706     
  Lines       50382   25876   -24506     
  Branches     1076     195     -881     
=========================================
- Hits        43792   17318   -26474     
- Misses       6353    8509    +2156     
+ Partials      237      49     -188     
Flag Coverage Δ
integrationtests 60.7% <100.0%> (-4.4%) ⬇️
unittests 84.1% <100.0%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...or_v2/modules/db/repositories/comp_tasks/_utils.py 72.7% <100.0%> (-2.3%) ⬇️

... and 979 files with indirect coverage changes

@sanderegg sanderegg force-pushed the hotfix/disable-update branch from 63cf347 to c52bbc1 Compare November 1, 2023 09:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c52bbc1 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg merged commit e41af2e into ITISFoundation:master Nov 1, 2023
@sanderegg sanderegg deleted the hotfix/disable-update branch November 1, 2023 11:13
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants