🐛 removed wrong injected metric from dynamic-sidecar
#5005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
requested review from
matusdrobuliak66,
mguidon,
mrnicegyu11,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Nov 9, 2023
pcrespov
approved these changes
Nov 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #5005 +/- ##
=========================================
- Coverage 87.2% 68.3% -18.9%
=========================================
Files 1243 521 -722
Lines 51141 26389 -24752
Branches 1081 195 -886
=========================================
- Hits 44625 18049 -26576
- Misses 6278 8291 +2013
+ Partials 238 49 -189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Nov 9, 2023
…om:GitHK/osparc-simcore-forked into pr-osparc-remove-promethus-injected-metric
|
Code Climate has analyzed commit 00407ac and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Injected metric was wrong, date was added in str format which is not supposed by prometheus .
Related issue/s
How to test
DevOps Checklist