Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 24, 2024

What do these changes do?

  • ⚠️ docker-compose: adds prefix with initials of service name to hostname
    • POSTGRES_CLIENT_NAME takes this value
    • Facilitates identifying db connections in the processes lists of postgres
  • ⚗️ increases RPC client timeout for new services calls (experimental) @odeimaiz
  • 🔨 Adds profiler in catalog's RPC

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov self-assigned this Jul 24, 2024
@pcrespov pcrespov added the a:catalog catalog service label Jul 24, 2024
@pcrespov pcrespov added this to the Tom Bombadil milestone Jul 24, 2024
@pcrespov pcrespov changed the title ♻️ WIP: Is5964/fixes catalog master 🔨♻️ Adds profiler tools for catalog Jul 24, 2024
@pcrespov pcrespov marked this pull request as ready for review July 24, 2024 14:35
@sonarqubecloud
Copy link

@pcrespov pcrespov changed the title 🔨♻️ Adds profiler tools for catalog 🔨♻️Profiling tools for catalog Jul 24, 2024
@pcrespov pcrespov enabled auto-merge (squash) July 24, 2024 14:40
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.1%. Comparing base (cafbf96) to head (53eaf94).
Report is 375 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6104      +/-   ##
=========================================
+ Coverage    84.5%   86.1%    +1.5%     
=========================================
  Files          10    1453    +1443     
  Lines         214   59757   +59543     
  Branches       25    1409    +1384     
=========================================
+ Hits          181   51472   +51291     
- Misses         23    7989    +7966     
- Partials       10     296     +286     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 84.0% <61.2%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/service-library/src/servicelib/async_utils.py 89.5% <100.0%> (ø)
...icelib/rabbitmq/rpc_interfaces/catalog/services.py 0.0% <0.0%> (ø)
...g/src/simcore_service_catalog/api/rpc/_services.py 91.8% <68.7%> (ø)
...brary/src/servicelib/utils_profiling_middleware.py 46.6% <50.0%> (ø)

... and 1407 files with indirect coverage changes

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comment ;)

@pcrespov pcrespov merged commit bcb0aa4 into ITISFoundation:master Jul 24, 2024
@pcrespov pcrespov deleted the is5964/fixes-catalog-master branch July 24, 2024 15:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:catalog catalog service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants