Skip to content

Conversation

@JoeyT1994
Copy link
Collaborator

Added utility functions for adding and removing lists of edges.

@JoeyT1994 JoeyT1994 changed the title Add_rem edges Adding and Removing Edge Lists Feb 2, 2023
@mtfishman
Copy link
Member

Thanks @JoeyT1994, I think this should go in: https://github.com/mtfishman/NamedGraphs.jl/blob/main/src/Graphs/abstractgraph.jl.

@mtfishman
Copy link
Member

Also could you add some tests?

@JoeyT1994
Copy link
Collaborator Author

Also could you add some tests?
Sure, I just added them.

@mtfishman
Copy link
Member

I added some checks for formatting. Could you format your code:

julia> cd(pkgdir(NamedGraphs))

julia> using JuliaFormatter

julia> format(".")

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #29 (25c3c37) into main (4dcbda7) will decrease coverage by 0.51%.
The diff coverage is 55.55%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   77.90%   77.39%   -0.51%     
==========================================
  Files          19       19              
  Lines         774      792      +18     
==========================================
+ Hits          603      613      +10     
- Misses        171      179       +8     
Impacted Files Coverage Δ
src/Graphs/abstractgraph.jl 52.97% <55.55%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mtfishman mtfishman merged commit 35be64d into ITensor:main Feb 2, 2023
@mtfishman
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants