Better definition

Author: mtfishman

src/abstractsparsearrayinterface.jl

@@ -54,10 +54,6 @@ end
   return error("Not implemented.")
 end
 
-@interface ::AbstractArrayInterface function isstored(a::SubArray, I::Int...)
-  return isstored(parent(a), Base.reindex(parentindices(a), I)...)
-end
-
 # TODO: Use `Base.to_indices`?
 isstored(a::AbstractArray, I::CartesianIndex) = isstored(a, Tuple(I)...)
 # TODO: Use `Base.to_indices`?
@@ -106,10 +102,6 @@ end
   SparseArraysBase.storedvalues(::T)
 end
 
-@derive (T=SubArray,) begin
-  SparseArraysBase.isstored(::T, ::Int...)
-end
-
 # TODO: Add `ndims` type parameter, like `Base.Broadcast.AbstractArrayStyle`.
 # TODO: This isn't used to define interface functions right now.
 # Currently, `@interface` expects an instance, probably it should take a

src/wrappers.jl

@@ -106,6 +106,10 @@ function storedparentvalues(a::SubArray)
   return StoredValues(parent(a), collect(eachstoredparentindex(a)))
 end
 
+@interface ::AbstractArrayInterface function isstored(a::SubArray, I::Int...)
+  return isstored(parent(a), index_to_parentindex(a, I...)...)
+end
+
 using LinearAlgebra: Transpose
 function parentindex_to_index(a::Transpose, I::CartesianIndex{2})
   return cartesianindex_reverse(I)